search

Addepar / ember-json-viewer

An Ember Addon that adds a json-viewer component for showing collapsible/expandable json.
https://addepar.github.io/ember-json-viewer
MIT License
3 stars 5 forks source link

Fix eslint issue with `isExpanded` computed property #11

Closed bantic closed 3 years ago

bantic commented 3 years ago

eslint was complaining about the unspecified _isExpanded dependency, and also side-effectful change of setting _isExpanded in the getter. Moving _isExpanded to a prop on the prototype seems to solve this issue.

@JimSchofield Does this work with your use case? I will release it in 0.6.3 in a moment. Apologies for not catching it earlier, the Github Actions were not running for external PRs and I didn't realize it.

JimSchofield commented 3 years ago

@bantic This works too. Thank you!