Addepar / ember-json-viewer

An Ember Addon that adds a json-viewer component for showing collapsible/expandable json.
https://addepar.github.io/ember-json-viewer
MIT License
3 stars 5 forks source link

Update `ember-test-selectors` #13

Closed bertdeblock closed 3 years ago

bantic commented 3 years ago

@bertdeblock thanks for the PR! The CI failure here seems to be unrelated, but I would like to get it green again before merging anything. I'll add to my list to take a look. I think that newer ember-beta (which is now Ember v4) is constructed in a way that the tests aren't anticipating. For instance, it removes window.Ember in https://github.com/emberjs/ember.js/pull/19678, and that seems to be the source of one of those errors.

bertdeblock commented 3 years ago

@bantic No problem! I was also planning on looking at what went wrong here, but haven't had the time yet.

bertdeblock commented 3 years ago

Closing in favour of #14.