Update Ember and dependencies

Addepar / ember-json-viewer

An Ember Addon that adds a json-viewer component for showing collapsible/expandable json.

https://addepar.github.io/ember-json-viewer

MIT License

3 stars 5 forks source link

Update Ember and dependencies #14

Closed bertdeblock closed 3 years ago

bertdeblock commented 3 years ago

Update to Ember v3.28 (using ember-cli-update)
Temp turn off most ESLint and Ember Template Lint rule violations (these can be resolved in a separate PR)
Prettify all code (using double quotes for now, which results in the least amount of changes)
Update the .npmignore file to ignore a couple more unneeded files

Should also resolve the issues we're running into in #13.

bantic commented 3 years ago

@bertdeblock 👏 👏 Thank you for taking the time to make these PRs! They look great! Unfortunately, we are using this addon internally with a somewhat older app (Ember 2.12), and your upgrades here appear to break for that older Ember version. I thought the "ember-classic" entry in our ember-try would cover it, but it seems like it isn't.

In order for me to be able to merge these PRs, we need to add back in Ember 2.12 to the ember-try and get those tests passing, sadly.

I will take a look at it as well when I am able to. If you have any ideas about how best to support Ember 2.12 then a PR would be very gratefully received!

bertdeblock commented 3 years ago

@bantic Let me see what I can do. Would be nice to land this as ember-freestyle depends on this addon.

bertdeblock commented 3 years ago

I can't get the master branch to pass against v2.12 locally. Don't think I have the time to further look into this. Are you guys using the latest version of ember-json-viewer in that app? The current ember-try config starts off with testing against v3.16.