search

Addepar / ember-json-viewer

An Ember Addon that adds a json-viewer component for showing collapsible/expandable json.
https://addepar.github.io/ember-json-viewer
MIT License
3 stars 5 forks source link

Upgrade ember-test-selectors and ember-cli-htmlbars #17

Closed NullVoxPopuli closed 2 years ago

NullVoxPopuli commented 2 years ago

ember-cli-htmlbars: https://github.com/ember-cli/ember-cli-htmlbars/blob/master/CHANGELOG.md ember-test-selectors: https://github.com/simplabs/ember-test-selectors/blob/master/CHANGELOG.md

The deprecation I'm wanting to eliminate:

NullVoxPopuli commented 2 years ago

gotta fix the ember 4+ stuff, one sec

NullVoxPopuli commented 2 years ago

Now I have to deal with:

Global error: Uncaught Error: 
Could not find module `@ember/application/deprecations` imported from
 `@ember/test-helpers/setup-rendering-context` at http://localhost:7357/assets/vendor.js, line 259

:sweat_smile:

NullVoxPopuli commented 2 years ago

Now we need this: code: https://github.com/ember-cli/ember-cli/blob/b24b73b388934796ca915ca665b48a27c857199b/lib/utilities/ember-app-utils.js#L130

rather than the version that does Ember.assert, so ember-cli gets upgraded now too (only affects tests)

NullVoxPopuli commented 2 years ago

that's all for now -- stuck on errors with ember 4+ -- maybe ya'll can handle it from there

mixonic commented 2 years ago

Wow, I just saw this, but there are a lot of changes outside of ember-test-selectors and ember-cli-htmlbars getting bumped. I've landed those two items in:

And I think that leaves this PR as something more like "add 3.28 to the CI suite, improve Ember 4 compat".

Regardless I'm going to go ahead and close it for now. 100% work will continue along these lines, and will likely use this PR as a starting point. I'd be very open to a PR adding Ember 3.28 to the CI suite and getting it green, then we can look at Ember 4 as a distinct effort.

Thanks for this spike @NullVoxPopuli! Onward!