Addepar / ember-table

https://opensource.addepar.com/ember-table/
Other
1.69k stars 355 forks source link

Unable to use the addon with current version of ember and embroider #1061

Open Polve opened 10 months ago

Polve commented 10 months ago

Using ember-cli 5.5, and creating a new project with the following flags:

ember new --typescript --embroider test-ember-table

Gives this error while building the app:

Some V1 ember addons are resolving as incorrect peer dependencies. This makes it impossible for us to safely convert them to v2 format.
  πŸ‘‡ πŸ‘‡ πŸ‘‡
πŸ‘‰ See https://github.com/embroider-build/embroider/blob/main/docs/peer-dependency-resolution-issues.md for an explanation of the problem and suggestions for fixing it.
  πŸ‘† πŸ‘† πŸ‘†

test-ember-table@0.0.0 (dev)-> ember-table@5.0.6 -> ember-classy-page-object@0.8.0-beta.2 -> ember-cli-page-object@2.0.0
    sees peerDep @ember/test-helpers@2.9.4
      at /sandbox/test-ember-table/node_modules/ember-classy-page-object/node_modules/@ember/test-helpers
    but test-ember-table@0.0.0 is using @ember/test-helpers@3.2.1
      at /sandbox/test-ember-table/node_modules/@ember/test-helpers

it's probably some kind of wrong dependency that can easily be fixed but I'm not technical enough to understand if/how

JamesS-M commented 1 month ago

Have you gotten this to work for you? I'm seeing the same thing while upgrading my app.

Polve commented 1 month ago

no, I moved on to other things hoping a new release of ember table would come out but for now no luck, it seems

JamesS-M commented 1 month ago

Alright I'll do the same. Luckily my usage is so simple that a regular html form should do the trick!

eflanagan0 commented 3 weeks ago

I would also appreciate this addon working with embroider-build. I believe the error comes from this line in ember-table's package.json: https://github.com/Addepar/ember-table/blob/57e66969f915e1b9d12ca729aedba3c12e010082/package.json#L37

You can workaround this by using your package manager's override to ignore ember-table's provided version and use whatever @ember/test-helpers version your application depends on. In my case, the project uses npm, so I overrode with:

  "overrides": {
    "@ember/test-helpers": "3"
  },