search

Addepar / ember-table

https://opensource.addepar.com/ember-table/
Other
1.7k stars 352 forks source link

missing `abort` typing for `onSelect` #1064

Open acdn-tsmith opened 7 months ago

acdn-tsmith commented 7 months ago

I have run across a typing issue when trying to consume the abort helper https://github.com/Addepar/ember-table/pull/918 with a multi select table. It doesn't appear that the typings have been updated: https://github.com/Addepar/ember-table/blob/master/types/components/ember-tbody/component.d.ts

I am using 5.0.6.

This is the error message I get.

Type '(selection: BlahModel | BlahModel[], { abort }: { ...; }) => void' is not assignable to type '(rows: BlahModel | BlahModel[]) => void'.
  Target signature provides too few arguments. Expected 2 or more, but got 1.

Thanks!