search

Addepar / ember-table

https://opensource.addepar.com/ember-table/
Other
1.69k stars 352 forks source link

An old version of ember-test-selectors is busting deprecation workflow: getWithDefault #846

Open NullVoxPopuli opened 3 years ago

NullVoxPopuli commented 3 years ago

This is resolved in v5: https://github.com/simplabs/ember-test-selectors/blob/master/CHANGELOG.md

mixonic commented 3 years ago

@NullVoxPopuli What does "busting deprecation workflow" mean?

NullVoxPopuli commented 3 years ago

I should have added more details. oof. My guess is either: Emmer-cli-dendency-checker error or the deprecations hadn't yet been updated to the new format? (Deprecation staging stuff?)

NullVoxPopuli commented 3 years ago

ok, now that I've seen this again, I can confirm:

folks using throwOnUnhandled: true must silence getWithDefault deprecations, because ember-table uses and old version of ember-test-selectors

BobrImperator commented 3 years ago

Seems like this could wait until 2.8 drop as per https://github.com/Addepar/ember-table/pull/884#issuecomment-805779479. or even longer actually, until it's decided to drop below 3.8 support - judging by provided changelog.

NullVoxPopuli commented 3 years ago

@BobrImperator, we are using ember-table version 3.0.2-1

BobrImperator commented 3 years ago

Still looks like EmberTable 3.0 intents to drop support for Ember <2.8, while ember-test-selectors 5.0 require Ember 3.8+ if i'm not mistaken. So until maintainers decide to drop versions below 3.8, we might have to live with the deprecation.

Please bear in mind, I'm not a maintainer, was just skimming through issues :D

References: https://github.com/simplabs/ember-test-selectors/blob/master/CHANGELOG.md https://github.com/Addepar/ember-table/releases/tag/v3.0.0