Addepar / ember-table

https://opensource.addepar.com/ember-table/
Other
1.69k stars 354 forks source link

Ember auto import related error getting thrown when installing ember table v4.0.0 #959

Open ahemed-haneen opened 2 years ago

ahemed-haneen commented 2 years ago

ember-cli - v3.28

ERROR Summary:

  - broccoliBuilderErrorStack: [undefined]
  - code: [undefined]
  - codeFrame: [undefined]
  - errorMessage: ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object
  - errorType: [undefined]
  - location:
    - column: [undefined]
    - file: [undefined]
    - line: [undefined]
  - message: ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object
  - name: Error
  - nodeAnnotation: [undefined]
  - nodeName: [undefined]
  - originalErrorMessage: [undefined]
  - stack: Error: **ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object**
    at Class.included (/home/developer/Projects/js/test-ember-table-app/node_modules/@embroider/addon-shim/src/index.js:51:27)
    at Class.superWrapper [as included] (/home/developer/Projects/js/test-ember-table-app/node_modules/core-object/lib/assign-properties.js:34:20)
    at /home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:497:26
    at Array.reduce (<anonymous>)
    at Class.eachAddonInvoke (/home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:494:24)
    at Class.included (/home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:769:10)
    at Class.superWrapper [as included] (/home/developer/Projects/js/test-ember-table-app/node_modules/core-object/lib/assign-properties.js:34:20)
    at /home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:497:26
    at Array.reduce (<anonymous>)
    at Class.eachAddonInvoke (/home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:494:24)

@mixonic any idea?

yaxinr commented 2 years ago

temporarily for pnpm add to packege.json

  "pnpm": {
    "overrides": {
      "ember-cli-page-object": "< 1.17.9"
    }
  },
ahemed-haneen commented 2 years ago

@yaxinr thankyou. i too had a hunch that downgrading to ember-classy-page-object@^0.7.0 would resolve this issue. but am using yarn(v1 - classic) as package manager so have no clue how to override in yarn

yaxinr commented 2 years ago

Yarn resolutions

On Thu, Aug 4, 2022, 16:09 Haneen Ahemed A @.***> wrote:

@yaxinr https://github.com/yaxinr thankyou. i too had a hunch that downgrading to ember-classy-page-object@^0.7.0 would resolve this issue. but am using yarn(v1 - classic) as package manager so have no clue how to override in yarn

— Reply to this email directly, view it on GitHub https://github.com/Addepar/ember-table/issues/959#issuecomment-1205109998, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALEFC2UWR5N5D7CPN3KRCTVXOQFVANCNFSM55NXSUGQ . You are receiving this because you were mentioned.Message ID: @.***>

ascudder commented 2 years ago

I opened a PR to try to fix this in the ember-classy-page-object repository, let me know if this helps: https://github.com/Addepar/ember-classy-page-object/pull/38

ginomiglio commented 2 years ago

This is specifically an incompatibility with ember-cli-page-object >= v2.0.0-beta.4. You can add a yarn resolution for v2.0.0-beta.3 to work around the problem in the cleanest way possible. See https://github.com/Addepar/ember-classy-page-object/issues/39 for details.

liberlanco commented 2 years ago

This is specifically an incompatibility with ember-cli-page-object >= v2.0.0-beta.4.

Thank you, that helped. I tried to fix version of ember-classy-page-object in dependencies without success, but then just added into package.json > dependencies list:

       "ember-cli-page-object": "v2.0.0-beta.3"

and now it works.

node@98e52f465a88:/app/client$ ember -v
ember-cli: 4.1.1
node: 14.20.0
ginomiglio commented 2 years ago

FYI https://github.com/Addepar/ember-classy-page-object/issues/39 was fixed and released, so if you use ember-classy-page-object v0.8.0-beta.2 this problem should no longer happen. We can probably close this issue now.

rreckonerr commented 2 years ago

@ginomiglio Is this issue possibly related to ember-cli-page-object/ember-classy-page-object?

ginomiglio commented 2 years ago

I'm not sure. I don't think so.