Addepar / ember-widgets

https://opensource.addepar.com/ember-widgets/#/ember-widgets/overview
Other
290 stars 79 forks source link

Fix a race condition between value/content #283

Closed mixonic closed 5 years ago

mixonic commented 5 years ago

Previously if a value argument was set before content had been set (which may happen during initialization) then a selection value would be set matching the value. This selection would probably be wrong, especially if optionValuePath is also present, meaning selection is expected to be an object.

This refactors some of the current implementation to make clearer what the code intent is, and makes these changes:

mixonic commented 5 years ago

I believe this work is on the right track, but I've given up on trying to land it into the downstream app. Closing this for now.