Addepar / ember-widgets

https://opensource.addepar.com/ember-widgets/#/ember-widgets/overview
Other
288 stars 75 forks source link

Add ability to display number of items under group header #298

Closed jiayingxu closed 5 years ago

jiayingxu commented 5 years ago

Add ability to display number of items under group header using numMembers property

Example usage: image

kpfefferle commented 5 years ago

Design question: should the continent names here be left-aligned? It appears from the screen capture that they are centered within an area of varying width which would likely lead to them not really looking aligned at all?

jiayingxu commented 5 years ago

I fixed the alignment in the screenshot. The screenshot is just of a demo I created locally where I hard-coded the number of items under the header with the countries label in select-item-layout. Overriding the default layout would require creating a view that overrides select-option.

mixonic commented 5 years ago

I think these are valid questions for the use case, but I'm not sure if they apply here in particular. Just passing the number through seems fine: