Addepar / ember-widgets

https://opensource.addepar.com/ember-widgets/#/ember-widgets/overview
Other
288 stars 75 forks source link

Move Dev-Only Dependencies from bower.json dependencies block #70

Closed blimmer closed 10 years ago

blimmer commented 10 years ago

There are several dependencies that appear to only be useful in development in the dependencies block of the bower.json.

Currently it's

  "dependencies": {
    "bootstrap": "~3.2.0",
    "ember": "~1.1.0",
    "font-awesome": "~4.0.3",
    "handlebars": "~1.3.0",
    "holder": "holderjs#1.9",
    "jquery": "1.9.1",
    "jquery-browser": "jquery.browser#~0.0.4",
    "lodash": "~1.2.1",
    "qunit": "~1.12.0",
    "rangy": "~1.2.3"
  },
  "devDependencies": {
    "sinonjs": "~1.7.3",
    "sinon-qunit": "~1.0.0"
  }

Things like holder and qunit are likely not required in a production setting, so they should be moved to the devDependencies section.

I'm not totally familiar with the ins-and-outs of this project, so I'd need to put in some time to move these things around (to make sure I didn't break anything). If I get some time, I'll try to submit a PR. For now we're using the dist/ js and css because of this problem (and the out-of-date versions problem described in #67 )

azirbel commented 10 years ago

Yep, you're right - thanks for mentioning it! PRs to clean up the bower.json file would definitely be appreciated. You can get a good idea of which dependencies are actually needed from the starter kit (currently http://emberjs.jsbin.com/xabeb/1/edit).

What do you mean when you say you're using the dist/ js and css? I'd expect you to be using those anyway, since that's what gets pulled in when you install ember-widgets via bower.

blimmer commented 10 years ago

Ah, sorry that was confusing. I'm just copying over the dist/ js and css into a vendor/ folder for my project and not using bower to manage the package at all.

blimmer commented 10 years ago

Closing. Resolved by PR #72