Additional-Mods / simplerauth

A Minecraft Fabric mod that adds server-side authentication.
https://modrinth.com/mod/simpler-auth
MIT License
9 stars 13 forks source link

Migrate player data when enabling online auth #22

Open Londiuh opened 3 years ago

Londiuh commented 3 years ago

Is your feature request related to a problem? Please describe. Not related to a problem, but losing your data when enabled online auth is annoying.

Describe the solution you'd like When a player enables online auth, their data gets migrated to the online UUID.

Version Mod version: 1.2.1 Minecraft version: 1.17 Fabric version: 0.7.4

Dqu1J commented 3 years ago

I don't know...

ghost commented 3 years ago

why is this function optional? if someone has an original client, they don't have to write a register and login .. the mod should be set to "forced-online-auth": true by default, and "optional-online-auth": false

this is how the mod should be configured by default and would actually only allow registration and login for non-original clients .. the original client would do nothing and just connect

then the situation with migration of uuid to another uuid would never occur

Dqu1J commented 3 years ago

When forced-online-auth is enabled, offline players using a username of an online account won't be able to log in. There are millions of existing online accounts, so forced-online-auth is not enabled by default.

ghost commented 3 years ago

maybe you're thinking about it wrong .. if you're building a new era of minecraft server here via FABRIC, it would be good to start thinking about changing your mindset .. i support non-original launchers, but let's get a name that no one bought. no stealing names

Londiuh commented 3 years ago

@PortableGames it's not sealing names. Sometimes non-premium players have usernames that coincidentally already exists and someone has an account with that name. And if forced-online-auth is enabled, it can be really annoying to them because maybe they play other servers and they have to change their username just to play your server.

PortableGames commented 3 years ago

@PortableGames it's not sealing names. Sometimes non-premium players have usernames that coincidentally already exists and someone has an account with that name. And if forced-online-auth is enabled, it can be really annoying to them because maybe they play other servers and they have to change their username just to play your server.

what I said is still true .. if non-original players want to play anywhere under a "as you say non-stolen nick" they are out of luck .. because maybe a player who bought the game wants to join and because of the stolen name it won't work and I as the owner will have to deal with unregister and verification of proof who is right;(

and that's why I again suggest to somehow detect that the name has not been verified on the mojang api .. and show the player a custom sentence like: you can't use the nickname of the player who bought the original game