AddonLab / AiOS

Repository of the Firefox extension All-in-One Sidebar
GNU General Public License v2.0
47 stars 15 forks source link

Apply / OK buttons not working when options saved #118

Closed mikolajek closed 8 years ago

mikolajek commented 8 years ago

AiOS 7.2.9 + FF48 on Windows 10 Anniversary x64 - when any option is changed in AiOS settings both Apply and OK buttons don't work when clicked, so the options can't be saved. At the same time Cancel button works perfectly and closes settings window.

JudgmentDay commented 8 years ago

Not sure about Windows 10, but I have Windows 7. For me, while the same effect of the OK and Apply buttons are not automatically closing the window, the changes are applied. You have to click the [x] on the upper right as another way to close the options window.

zetavu commented 8 years ago

Not only do those buttons not work but the changes made do not always apply. AiOS 7.29 and FF48 are completely broken, I cannot get sidebar to open. When I downgrade to 7.28 or 7.27 in FF48, sidebar works but not well, history etc open in a new window not in panel, regardless of what I change in settings. I had to downgrade FF to 47.0.1 and AiOS to 7.27 (had issues with 7.28, not sure why) to get back functionality. Those versions won't work with FF 48 so it is an FF 48 issue. Tried in both W10 and W7 on separate machines. Note, sometimes you had to restart FF to get the issue, may have required a reboot. Made it harder to diagnose.

mikolajek commented 8 years ago

I've downgraded to 7.2.8 and everything works fine. Hope any issues are related to Mozilla's plugins approach that has been changing in the last months.

RDL-github commented 8 years ago

I can confirm that this problem is fixed for me by AiOS 0.7.30

when using FF 48.0.1 x64 in Win 10 (Aniv) x64.

VBRR