search

Addyvan / valheim-k8s

valheim game-server on kubernetes
MIT License
94 stars 45 forks source link

Please use the Release name in the name of created k8s objects #42

Closed TBBle closed 1 year ago

TBBle commented 2 years ago

Using the Release name in the k8s object names ensures that multiple installations of the chart in a single namespace cannot conflict, and also helps identify resources that belong together.

The default helm create template provides an example for this as a named template <CHART>.fullname, which also supports overriding either the entire 'fullname' or just the .Chart.Name aspect, and can then be used as the name or name prefix for objects created by the chart.

Helpfully, all resources currently created have "valheim-server" as a name or prefix, so this is a reasonably easy thing to change.

However, for continuity when upgrading, either the default for fullnameOverride would be "valheim-server", and that's stuck there forever, or at some point users upgrading need to know to add that setting to their config when upgrading. Either one is a pain. >_<

todaywasawesome commented 1 year ago

Fixed in #50

Addyvan commented 1 year ago

Fixed in #50

Yep, closing.