Addyvan / valheim-k8s

valheim game-server on kubernetes
MIT License
94 stars 45 forks source link

Please consider marking the world-data PVC as "do not delete" #43

Open TBBle opened 2 years ago

TBBle commented 2 years ago

To avoid surprise world-data loss when upgrading or modifying charts, I'd suggest marking the world-data PVC with the "helm.sh/resource-policy": keep annotation.

It might make sense for this to be configurable in the values.yaml, both to support existing behaviour, and to not surprise users who expect to lose their data when uninstalling the chart.

I'm not sure about doing the same thing for the server-data PVC, since it's not unique/special, just big. It's hence more-costly to forget, i.e. 60c/month on AWS EBS vs 12c/month for the world-data.