search

AdeelK93 / collapsibleTree

Create Interactive Collapsible Tree Diagrams in R using D3.js
https://adeelk93.github.io/collapsibleTree/
159 stars 41 forks source link

deprecated Node$fields #59

Closed bhogan-mitre closed 3 years ago

bhogan-mitre commented 4 years ago

The data.tree package is deprecating Node$fields in favor of Node$attributes. This is leading to a lot of warnings for users that are on the development version of data.tree.

[1] "Node$fields will be deprecated in the next release. Please use Node$attributes instead."
[1] "Node$fields will be deprecated in the next release. Please use Node$attributes instead."
[1] "Node$fields will be deprecated in the next release. Please use Node$attributes instead."
...

This seems like a fairly trivial adjustment is needed here. I'm happy to submit a PR if you're open to it. Thanks for considering.

AdeelK93 commented 4 years ago

Thanks for bringing this to my attention, I would love if you submitted a PR for this

bhogan-mitre commented 3 years ago

Checking in on this one. Let me know if you have questions on the PR or need anything else here @AdeelK93. Thanks.

AdeelK93 commented 3 years ago

Oh sorry I totally missed this! Merged

bhogan-mitre commented 3 years ago

No worries, thanks!