search

AdelRedaa97 / react-native-select-dropdown

react-native-select-dropdown is a highly customized dropdown | select | picker | menu for react native that works for andriod and iOS platforms.
MIT License
312 stars 133 forks source link

Modal does not reset height after search results change #155

Closed mattlewer closed 3 months ago

mattlewer commented 9 months ago

I fire an API request when the user searches which then populates the dropdown list, unfortunately the modal does not re-establish it's height and therefore the results run off the screen with no way to access them.

I would expect the modal to reduce it's height to fit. I've fixed this by hardcoding the height, but i'd rather it was responsive. In the example below my drop down had borders top and bottom, but as you can see, the bottom is off the screen.

Screenshot 2023-09-20 at 10 34 29

AdelRedaa97 commented 3 months ago

Fixed in v4.0 take a look at the changes made in v4.0 https://github.com/AdelRedaa97/react-native-select-dropdown?tab=readme-ov-file#-major-changes

Feel free to open the issue again if it still exists