Ademking / BetterViewer

a replacement for the image viewing mode built into Firefox and Chrome-based web browsers.
MIT License
247 stars 19 forks source link

Alt+D hijacking? #31

Closed SpitFire-666 closed 1 year ago

SpitFire-666 commented 2 years ago

Describe the bug

When viewing an image in BetterViewer tab, the Alt+D key combo to focus the address bar no longer works

To Reproduce Steps to reproduce the behavior:

  1. Open an image so that BetterViewer loads it
  2. Press Alt+D (on Windows at least)

Expected behavior Address bar should be focused, but isn't - I think BetterViewer is hijacking that keyboard shortcut

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context This may be by design and not a bug 🤷‍♂️, but I use Alt+D (standard shortcut for focusing the address bar since the dawn of time) all the time! Thanks

Ademking commented 2 years ago

@SpitFire-666 Thank you so much for your feedback! 👍 You're right. I will fix this and It will be in the available in the next update

SpitFire-666 commented 2 years ago

Also just noticed F5 and Ctrl+R don't work (I want to refresh the image for testing). Can raise another issue if you want. Cheers!

skagon commented 2 years ago

I will second that and also add that even Ctrl+S has been rendered inoperative. I can't save the image at all, which is highly annoying. Please fix that also.

W0ofles commented 2 years ago

Can we possibly make the Ctrl+D a toggle-able option? I saw the notification for the bug and went to test it and I actually kind of like that it displays details and doesn't highlight the address bar

W0ofles commented 2 years ago

Im dumb.. its Alt+D... Disregard.

Sevenics commented 2 years ago

I also find it terribly irritating how Ctrl+P, and generally universal shotcut to Print, is no longer Print. Instead It opens Paint, a function I have no interest in. And disabling the paint function simply make Ctrl+P a dead shortcut.

Instead Print has been rebound to Ctrl+M, a shortcut that makes it conflict with Firefox Mute Tab shortkey.