search

Ademking / BetterViewer

a replacement for the image viewing mode built into Firefox and Chrome-based web browsers.
MIT License
247 stars 19 forks source link

BetterViewer fork #56

Closed Bamajon1974 closed 9 months ago

Bamajon1974 commented 9 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Bamajon1974 commented 9 months ago

Has any BetterViewer fork been uploaded into the Firefox and Chrome stores? No reply from the author if the extension will be maintained and developed further.

Ademking commented 9 months ago

Has any BetterViewer fork been uploaded into the Firefox and Chrome stores? No reply from the author if the extension will be maintained and developed further.

Hello @Bamajon1974, I'm the maker of BetterViewer. I deeply apologize for the lack of updates on BetterViewer. Due to commitments in my studies and work, I've been unable to dedicate time to the project recently. However, I believe in the potential of this extension and its community. I encourage anyone interested to contribute to the project... Thank you for your understanding and support.

Bamajon1974 commented 9 months ago

@Ademking thank you for the reply and update.

Bamajon1974 commented 9 months ago

Good evening

Thank you for the reply and update. Just one question though....does the current version of BetterView support manifest v3 before v2 extensions are removed from the chrome webstore next year?

Thanks, Jon

On Tue, Nov 21, 2023 at 7:18 AM Adem Kouki @.***> wrote:

Has any BetterViewer fork been uploaded into the Firefox and Chrome stores? No reply from the author if the extension will be maintained and developed further.

Hello @Bamajon1974 https://github.com/Bamajon1974, I'm the maker of BetterViewer. I deeply apologize for the lack of updates on BetterViewer. Due to commitments in my studies and work, I've been unable to dedicate time to the project recently. However, I believe in the potential of this extension and its community. I encourage anyone interested to contribute to the project... Thank you for your understanding and support.

— Reply to this email directly, view it on GitHub https://github.com/Ademking/BetterViewer/issues/56#issuecomment-1820816679, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRG3AUCIIGU7INVWAXDA2DYFSL3HAVCNFSM6AAAAAA7TRD6WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQHAYTMNRXHE . You are receiving this because you were mentioned.Message ID: @.***>

Metacor commented 9 months ago

Currently BetterViewer is dependent on Manifest V2 APIs, and as such, would need to be modified to work with Manifest V3.

If I can remember correctly, BetterViewer listens for the Header information when a new tab is loaded, and then activates if it matches the MIME type of Image. I believe in order to stop the original page from loading, and instead load it in the extension's environment, the permission API "webRequestBlocking" is used, which is disabled in Manifest V3 and instead is replaced with "declarativeNetRequest", which requires the use of rulesets to set permissions.

I haven't personally tried to implement the new API so I'm not sure on the exact requirements, but the viability on updating to MV3 rests on whether or not you have to explicitly state every individual website host you intend to use with rulesets. Either way, in its current state, BetterViewer is not MV3 compliant.

Bamajon1974 commented 9 months ago

Good afternoon

Thank you for the update and clarification. The manifest v3 update was the main question I had. I am not sure how fast Google will remove the extensions that don't support manifest v3. But I will be on the lookout for a fork uploaded to webstore or else a new viewer extension.

-Jon

On Sun, Nov 26, 2023 at 6:23 PM Metacor @.***> wrote:

Currently BetterViewer is dependent on Manifest V2 APIs, and as such, would need to be modified to work with Manifest V3.

If I can remember correctly, BetterViewer listens for the Header information when a new tab is loaded, and then activates if it matches the MIME type of Image. I believe in order to stop the original page from loading, and instead load it in the extension's environment, the permission API "webRequestBlocking" is used, which is disabled in Manifest V3 and instead is replaced with "declarativeNetRequest", which requires the use of rulesets to set permissions.

I haven't personally tried to implement the new API so I'm not sure on the exact requirements, but the viability on updating to MV3 rests on whether or not you have to explicitly state every individual website host you intend to use with rulesets. Either way, in its current state, BetterViewer is not MV3 compliant.

— Reply to this email directly, view it on GitHub https://github.com/Ademking/BetterViewer/issues/56#issuecomment-1826935734, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRG3ASE3EDPSGTYMSITGBTYGPFORAVCNFSM6AAAAAA7TRD6WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWHEZTKNZTGQ . You are receiving this because you were mentioned.Message ID: @.***>