Don't you think `AsymmetricPair` is redundancy?

AdeptLanguage / Adept

The Adept Programming Language

GNU General Public License v3.0

120 stars 8 forks source link

Don't you think `AsymmetricPair` is redundancy? #314

Closed ghost closed 6 months ago

ghost commented 6 months ago

Pair is enough. It doesn't take longer to write <T, T> Pair than <T> Pair. Please remove AsymmetricPair and extend Pair.

IsaacShelton commented 6 months ago

Yes AsymmetricPair is a pretty bad name and was a terrible mistake. Ideally there would be a way to fix this without breaking backwards compatibility.

I've got a potential solution which might fix this soon

IsaacShelton commented 6 months ago

Fixed in https://github.com/AdeptLanguage/AdeptImport/commit/a94a373cb8cebdeb51703dbeac71e95bcd33829f

These changes are fully backward compatible, so old code will still work.

<$T, $S> AsymmetricPair has been replaced with <$T, $S> Pair
<$T> Pair is still valid, but has been replaced under the hood with alias <$T> Pair = <$T, $T> Pair

🎉