Closed chihung93 closed 1 year ago
@chihung93 sorry for the late review.
First of all, I would like to thank you for your contribution. It's very welcome!
In order to properly review your PR please could add a screenshot with the final result?
Also, please revert the Readme changes because it's difficult to read it if you change all the file with no needed modifications.
Many thanks!
Hi @ferranpons , thanks for your response, My google account console is expired now, Im trying to find some key to take a screenshot it.
https://user-images.githubusercontent.com/5199109/202866200-73f97421-ccf0-49b9-b95d-67329e4f18a3.mp4
Hi @ferranpons , I record a video for this PR
@chihung93 You need to correct these Ktlint issues to be able to merge:
@chihung93 You need to correct these Ktlint issues to be able to merge:
Fixed! Thanks.
@chihung93 The build is still not passing. Please review the lint issues:
Checkout the build result here: https://github.com/AdevintaSpain/Leku/actions/runs/4126569199/jobs/7129972752
I have run ./gradlew :leku:ktlintMainSourceSetCheck . I believe that its good to go live.
@chihung93 Many thanks for your contribution!
I have added a customize makers for Current location and other location