AdevintaSpain / Leku

:earth_africa: Map location picker component for Android. Based on Google Maps. An alternative to Google Place Picker.
https://adevintaspain.github.io/Leku/
Apache License 2.0
763 stars 170 forks source link

Feat/customize makers #367

Closed chihung93 closed 1 year ago

chihung93 commented 1 year ago

I have added a customize makers for Current location and other location

ferranpons commented 1 year ago

@chihung93 sorry for the late review.

First of all, I would like to thank you for your contribution. It's very welcome!

In order to properly review your PR please could add a screenshot with the final result?

Also, please revert the Readme changes because it's difficult to read it if you change all the file with no needed modifications.

Many thanks!

chihung93 commented 1 year ago

Hi @ferranpons , thanks for your response, My google account console is expired now, Im trying to find some key to take a screenshot it.

chihung93 commented 1 year ago

https://user-images.githubusercontent.com/5199109/202866200-73f97421-ccf0-49b9-b95d-67329e4f18a3.mp4

Hi @ferranpons , I record a video for this PR

ferranpons commented 1 year ago

@chihung93 You need to correct these Ktlint issues to be able to merge:

Captura de pantalla 2023-02-08 a las 10 21 25

chihung93 commented 1 year ago

@chihung93 You need to correct these Ktlint issues to be able to merge:

Captura de pantalla 2023-02-08 a las 10 21 25

Screenshot 2023-02-08 at 23 59 32

Fixed! Thanks.

ferranpons commented 1 year ago

@chihung93 The build is still not passing. Please review the lint issues:

Captura de pantalla 2023-02-20 a las 9 42 34

Checkout the build result here: https://github.com/AdevintaSpain/Leku/actions/runs/4126569199/jobs/7129972752

chihung93 commented 1 year ago

I have run ./gradlew :leku:ktlintMainSourceSetCheck . I believe that its good to go live.

Screenshot 2023-02-24 at 01 48 58
ferranpons commented 1 year ago

@chihung93 Many thanks for your contribution!