search

AdevintaSpain / TaggingViewer

Visualize live on-screen all the tagging that is occurring in your application
Other
8 stars 1 forks source link

Unintuitive spaces when activity separator is disabled #8

Open Sloy opened 1 year ago

Sloy commented 1 year ago

When "named separator" is disabled, the overlay doesn't show activity names but instead adds a space between events.

My application uses a mix of activity and fragment navigation, so these spaces are completely inconsistent. Also, since the event list is limited to 10, they remove valuable space from the event list. If I have 5 activity navigations, the overlay can only display 5 events. It even accumulates spaces (can't reproduce that in the sample).

My suggestion is to remove this space completely. In my opinion, it makes no sense to disable the separators but still have them occupying space. An alternative is to add another option to disable the spaces, but I think that would complicate the API too much.

I can open a PR for this, but I'd like to know what do the owners think first. https://github.com/AdevintaSpain/TaggingViewer/blob/main/taggingviewer/src/main/java/com/adevinta/android/taggingviewer/TaggingViewer.kt#L35

alorma commented 1 year ago

Go for it!

Anyway, I'm planning to redo this view with compose... I will start with detail screen, so as you wish!

Sloy commented 1 year ago

Careful with that. You will force Compose (one specific version) to all consumers. It could break some projects (ehem).