AdguardTeam / AGLint

Universal adblock filter list linter
https://www.npmjs.com/package/@adguard/aglint
MIT License
51 stars 3 forks source link

Add redirect-rule #124

Closed piquark6046 closed 1 year ago

scripthunter7 commented 1 year ago

@ameshkov At this point an interesting question arises. In this modifier entry, we can well specify which type of redirects are supported by each adblocker, but at the same time we currently have a separate compatibility table for redirects. Do you think it's necessary to handle redirects in a separate compatibility table, or is it enough to handle the redirect modifier this way? When I designed the first version of the compatibility table, I started the thinking from the Scriptlets library, so I created a separate compatibility table for redirects. The separate compatibility table has the following extras:

ameshkov commented 1 year ago

@scripthunter7 tbh, I think a separate compatibility table for each redirect resource / scriptlet is a more flexible option.

scripthunter7 commented 1 year ago

@ameshkov OK by me, but then this modifier should be handled separately as a special case. Scriptlets are definitely handled in a separate compatibility table, I was only thinking about redirects

ameshkov commented 1 year ago

@scripthunter7 oh, my bad. Redirect resources are not that important to handle as a special case. It'd still be better to have them defined separately, but we can do it later if that speeds things up.

scripthunter7 commented 1 year ago

Ok, then I'll merge this PR and temporarily remove the redirects compatibility table. I'm opening an issue so if we want to handle the redirect resources in more detail, we have somewhere to return to

scripthunter7 commented 1 year ago

@Alex-302 Please take a look, if you also think everything is OK, we'll merge this PR and sort out related things