search

AdguardTeam / AdGuardForSafari

AdGuard for Safari app extension
GNU General Public License v3.0
1.06k stars 75 forks source link

Forced switching to dedicated videocard #110

Closed MrVerard closed 5 years ago

MrVerard commented 5 years ago

Steps to reproduce

  1. Normal using of application
  2. Default settings and filters

Expected behavior

Actual behavior

MacOs switches to dedicated video card even on blank pages of safari, no other apps are running on system or safari

Screenshots:

Your environment

maciboy commented 5 years ago

Hi, this is indeed the only major issue I came across… I'm also using a MacBook Pro with integrated and dedicated graphics. Using gfxCardStatus one can see that AdGuard for Safari is triggering the dedicated card. I assume this is due the the Electron app and due to the usage of Chromium within the bundle :(

Spotify earlier had the same issue, since their Mac app is also based on Chromium. Meanwhile, they added a menu item to their app to let the user decide to turn on/off hardware acceleration. Before that, one could run Spotify with an additional argument. I believe it was something like „—disable -gpu“…

So, long story short, I believe that for a adblocker nobody needs hardware acceleration. Therefore, would it be possible to at least make it optional? Here is a thread about a possible solution to turn off the usage of dedicated graphics: https://github.com/electron-userland/electron-packager/issues/418

bildschirmfoto 2018-12-22 um 15 25 21

ameshkov commented 5 years ago

@maciboy thanks for the link, we'll take a look!

maciboy commented 5 years ago

Sounds good, thanks in advance! Btw, this is a link to the Spotify community, where first the option to start Spotify with an additional flag is proposed and later the included menu item is shown: https://community.spotify.com/t5/Desktop-Mac/Spotify-Desktop-Mac-requires-discrete-GPU/m-p/4476202#M532544

maciboy commented 5 years ago

Todays release notes say „[Fixed] Forced switching to dedicated video card“ However, for me Adguard is still triggering the Nvidia card… Was that meant to be fixed with this update?

MrVerard commented 5 years ago

@maciboy I'll give it a try, mine mbp has an amd HD6xxx

zzebrum commented 5 years ago

@MrVerard @maciboy how it goes? I can't repro the issue.

zzebrum commented 5 years ago

reopen if needed