AdguardTeam / AdGuardForSafari

AdGuard for Safari app extension
GNU General Public License v3.0
1.05k stars 74 forks source link

Can we have a Twitter Ad blocker? #163

Open Southpaw1496 opened 5 years ago

Southpaw1496 commented 5 years ago

My friend has this with his Ad Blocker (AdBlocker Ultimate) and I'm really jealous

ameshkov commented 5 years ago

Well, AdGuard for Safari should block Twitter ads just okay. Isn't it in your case?

Also, AdBlocker Ultimate is a simple rip-off of our old Safari extension.

Southpaw1496 commented 5 years ago

No, it doesn't. I'm worried if I create a filter it will block everything in my timeline

ameshkov commented 5 years ago

What filters do you have enabled? Could it be that you hit the 50k limit?

Southpaw1496 commented 5 years ago

It says I have three filters and 32744 rules

ameshkov commented 5 years ago

@slavaleleka could you please take a look?

slavaleleka commented 5 years ago

@AppleAuthority if AdGuard Base filter enabled there is no ad on my end — twitter.com##.promoted-trend blocks it. So, first of all, try to add this rule to user filter

Southpaw1496 commented 5 years ago

I did and nothing happened. I also tried reinstalling it, and it really looks like it's trying Screen Recording 2019-05-23 at 9 51 20 am

zzebrum commented 5 years ago

@AppleAuthority can you check in incognito mode, please? Can't repro either.

Southpaw1496 commented 5 years ago

Did, and I also disabled my other extensions. Nothing

TheHasagi commented 5 years ago

@AppleAuthority

Please, update filters and try again.

Southpaw1496 commented 5 years ago

@TheHasagi It's...Trying...So...Hard! ezgif com-video-to-gif

zzebrum commented 5 years ago

@AppleAuthority have you tried to delete cookies for twitter?

Southpaw1496 commented 5 years ago

No, why would that help?

On 30 Jul 2019, at 12:12, zzebrum notifications@github.com wrote:

@AppleAuthority https://github.com/AppleAuthority have you tried to delete cookies for twitter?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/163?email_source=notifications&email_token=AKV22INPG7EVCCV3SKARNYLQCAOZBA5CNFSM4HMNTRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3DUBMA#issuecomment-516374704, or mute the thread https://github.com/notifications/unsubscribe-auth/AKV22IITJMTJMH7D23TJWT3QCAOZBANCNFSM4HMNTRFQ.