AdguardTeam / AdGuardForSafari

AdGuard for Safari app extension
GNU General Public License v3.0
1.03k stars 72 forks source link

AdGuard blocks embedded twitter tweets #312

Closed tiiiecherle closed 4 years ago

tiiiecherle commented 4 years ago

Prerequisites

Issue Details

Expected Behavior

I don't know if this is expected behavior, but I would like to see embedded twitter tweets on the websites I visit.

Actual Behavior

Embedded twitter tweets are not shown or shown shortened or as text only.

Additional Information

The problem is not occurring when deactivating Safari - Preferences - Extensions - AdGuard Social.

It can easily be tested on multiple websites, e.g.

I don't know if this is intentional when the specified extension is enabled or if it is a rule issue.

If or if not a rule issue I'd like to know if the following user rules are the correct way and correct syntax to allow embedded twitter tweets specifically.

### unblock embedded twitter
# per domain
@@/tweets.json$domain=nba.com
@@/tweets.json$domain=sport1.de

# for all websites
@@||platform.twitter.com/widgets.js (not actually needed right now)
@@||syndication.twimg.com/tweets.json?*

# or for all websites
@@/tweets.json

Websites have to be reloaded or cache cleaned after applying the rules, but they are all working.

So there are three questions:

  1. Is the syntax of the above rules correct (they are working) or do they have to be optimized to have the latest supported syntax and to avoid side effects (unblocking stuff that should not be unblocked)?

  2. Is this a rule issue or intended behavior?

  3. Is there already a place (wiki, documentation) where these kind of working examples can be found by other users? It took me quite some time to figure them out with the help of the documentation and some google searching. But I did not find a place containing these kind of working rules with up-to-date syntax.

As it seems to concern rules feel free to move the issue to the correct place inside the Adguard GitHub development.

Thanks for looking into it.

Kind regards.

ameshkov commented 4 years ago

Issue moved to AdguardTeam/AdguardFilters #48693 via ZenHub