search

AdguardTeam / AdGuardForSafari

AdGuard for Safari app extension
GNU General Public License v3.0
1.05k stars 74 forks source link

AdGuard messed up YouTube's UI #536

Closed MrNorthernWolf closed 3 years ago

MrNorthernWolf commented 3 years ago

Issue Details

Expected Behavior

AdGuard somehow breaks YouTube, it worked correctly for a while but now AdGuard will mess up YouTube's UI, check the attached screenshot, and notice how videos goes under the profile banner, once AdGuard is turned off the UI goes back to normal.

Actual Behavior

AdGuard messed up YouTube's UI

Screenshot

Screen Shot 2021-02-22 at 6 24 34 PM

Additional Information

I also have a .log file ready to go.

adg_safari_logs_1614011094654.zip

crgmrgn commented 3 years ago

Seeing similar here, although the biggest issue is that it causes the left sidebar content to be positioned vertically too high, such that the YouTube logo and hamburger obscure the top 3x items in the sidebar. If you scroll the content pane upward (which takes the attached logo bar with it), you can glean some of the items in the sidebar, but not all.

It seems that the vertical position of the sidebar has been derived from the screen origin, rather than the active window or similar, which offsets the sidebar by about the top ~50-60px (window header + tab bar + YT logo bar?).

BTW, this is on the "full" sidebar (with textual descriptions of items and expanded subs list), not the purely pictorial shortened sidebar id'ed here in the screenshot.

MrNorthernWolf commented 3 years ago

I noticed that too on the sidebar, subscriptions tab actually disappears and it will lift the rest of the website UI up.

AdamWr commented 3 years ago

Hello,

Do you have Web Annoyances Ultralist enabled in AdGuard settings? If so, it's probably related to this issue - https://github.com/yourduskquibbles/webannoyances/issues/287

Could you please try to update filters or add this rule to user filter: youtube.com#@$##contentContainer { padding-top: 0 !important; } or just disable Web Annoyances Ultralist then wait about 30-60 as changes will be applied (please do not close AdGuard) and check if issue still occurs?

crgmrgn commented 3 years ago

Interesting, checked this morning and the issue with sidebar visibility (and scrolling) is resolved. Checking the filters, the Web Annoyances Ultralist that was potentially incriminated has not seen an update since ~1wk ago (v1.0.7.13), so no fix came from there …

The AdGuard Annoyances filter though (v2.0.72.45) is extremely recent, was it the real issue? Or did someone push the work-around via the AdGuard filter.

Just odd that I settled in this AM to do some testing/elimination and the issue was resolved for me (macOS 10.13.6, AdGuard 1.8.10).

AdamWr commented 3 years ago

We had a lot of reports with issues like this, for example - https://github.com/AdguardTeam/AdguardFilters/issues/74155#issuecomment-782886710 and many below, so yesterday I added a fix to AdGuard Base filter - https://github.com/AdguardTeam/AdguardFilters/commit/e6f34f72fe27674a0360610b583e35511bd396de until it will be fixed in Web Annoyances Ultralist.

MrNorthernWolf commented 3 years ago

I confirm this issue as FIXED also, changes that @AdamWr did fixed the issue.

You can close this issue if you like.

crgmrgn commented 3 years ago

We had a lot of reports with issues like this, for example - AdguardTeam/AdguardFilters#74155 (comment) and many below, so yesterday I added a fix to AdGuard Base filter - AdguardTeam/AdguardFilters@e6f34f7 until it will be fixed in Web Annoyances Ultralist.

Ah, thought that might be it … thanks.