search

AdguardTeam / AdGuardForSafari

AdGuard for Safari app extension
GNU General Public License v3.0
1.04k stars 74 forks source link

Twitter promoted posts sneaking through, fixed with disable/enable #630

Open Birbber opened 3 years ago

Birbber commented 3 years ago

@sporkman commented on Wed Jun 30 2021

Issue Details

Expected Behavior

Promoted Tweets on Twitter are blocked

Actual Behavior

Promoted Tweets are not blocked UNLESS I visit twitter, deselect "enabled on this website" in the AdGuard browser bar menu, then reselect "enabled on this website". The page reloads on reselecting and at that point promoted tweets are blocked again. If I close the tab and visit again, promoted ads will show until I repeat this process of disable/enable.

Screenshots

N/A

Additional Information

I have restarted my mac, restarted safari, and adguard.

sporkman commented 3 years ago

Here's another datapoint regarding the on/off toggling of AdGuard for Twitter.com:

Seems interesting that if the starting state is disabled, the single toggle to "enabled" doesn't fix it, but "enable/disable/enable" does.

Birbber commented 3 years ago

@sporkman Hello. Please check this behavior in version 1.10.4. It should have been fixed.

sporkman commented 3 years ago

Just updated, still seeing promoted tweets. Latest AdGuard and Safari Version 14.1.2 (14611.3.10.1.5).

I'll do some more checking, restart Safari, maybe reboot and circle back here...

Screen Shot 2021-08-03 at 2 20 35 PM Screen Shot 2021-08-03 at 2 19 05 PM

sporkman commented 3 years ago

Still getting promoted tweets after restarting safari. Same behavior - if I open a tab, load twitter disable adguard, and then enable it things are blocked. If I just open a tab and load, promoted tweets show.

tvinzz commented 3 years ago

@sporkman, do yo use v1.10.4? Please try to remove cached data for twitter.com in Safari browser settings and the problem should gone.

sporkman commented 3 years ago

I think it's working now, but man, did I have to go nuts on clearing things out. First tried the simple "Develop -> Empty Caches", then various force-reload, then clearing all the local storage (not the cache proper) that's only available in the web inspector, and still no good. When I went in the inspector and repeated that, along with removing all cookies, that seems to have done it. Honestly don't get how the cookie-cleaning fixed it.

Attaching a snapshot of the local storage that was cleared, for the benefit of anyone having a similar issue.

Oops, spoke too soon. Opened a tab to get a screenshot and was greeted by a promoted tweet.

Same thing works - if I disable AdGuard, then re-enable it, blocking works.

Anything I can provide for troubleshooting? Safari is Version 14.1.2 (14611.3.10.1.5), OS is 10.14.6, AdGuard is 1.10.4 and filters were updated before I did all this testing.

Screen Shot 2021-08-05 at 3 39 38 PM Screen Shot 2021-08-05 at 3 42 03 PM
tvinzz commented 3 years ago

@sporkman, thank you for your report. Can you please export logs and settings, it will help us to fix the problem.

sporkman commented 3 years ago

Sure, is there any sensitive information in the settings or logs? Generally I don't publicly post any logs that I don't really know the contents of or what PII is in there. I'd be fine with somehow directly providing them.

Birbber commented 3 years ago

@sporkman You can send it to apple@adguard.com. Nobody is going to see it, except for our developers. Make sure to mention this ticket's number in your email.

Birbber commented 3 years ago

@sporkman Thanks, logs have been received by our devs. We will let you know right after we get any information.

sporkman commented 3 years ago

Need anything else? Still happening most of the time, still fixed with the "off/on" trick. Weird stuff!

sporkman commented 3 years ago

Still happening. Latest updates, safari is Version 14.1.2 (14611.3.10.1.7).

apricot23 commented 3 years ago

Issue has persisted for me, as well.

sporkman commented 3 years ago

I'll note that Macheist is offering deals on the paid version (https://www.macheist.com/brands/adguard), but this issue lingering for so long is kind of souring me on moving to paid.

Birbber commented 3 years ago

@sporkman Sent a test build on your mail. Please try it.

sporkman commented 3 years ago

I've got it in place and it seems good so far. I'd like to give it a day or two though to be sure...

Birbber commented 3 years ago

@sporkman Sure, let us know the result later on.

sporkman commented 3 years ago

Spoke too soon. Promoted tweets tarted leaking through again. I have the logging enabled in the adguard settings, so attaching what's in the console (lots of noise though about the ".map" files). Restarted adguard (and verified w/ps that it really was stopped), restarted safari, cleared cache ("Develop -> Empty Caches"). Will be restarting the mac in a bit to see if that does anything.

Anything I can gather for you?

Also the trick of disabling and re-enabling adguard still works.

Screen Shot 2021-09-23 at 2 06 28 PM Screen Shot 2021-09-23 at 2 06 50 PM Screen Shot 2021-09-23 at 2 07 06 PM
sporkman commented 3 years ago

Rebooted, restarted, etc. and still happening... Anything else to look at? Can you folks reproduce?

I can try testing on a new user account if you think that might help. I'm also hanging back on 10.14 due to some 32-bit apps I need, could the OS version be an issue?

Birbber commented 3 years ago

@sporkman It seems our developers detected the issue. Will try to fix it with the next release. Thanks for your patience.

sporkman commented 2 years ago

Any updates?

sporkman commented 2 years ago

Also, just bought AdGuard Mac, and sadly that seems to let even more promoted tweets through... :(