AdguardTeam / AdGuardForSafari

AdGuard for Safari app extension
GNU General Public License v3.0
1.04k stars 74 forks source link

MacOS update 12.1 no longer blocking any of previous blocked elements on ALL of those sites #672

Closed avincent98144 closed 2 years ago

avincent98144 commented 2 years ago

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

Issue Details

MacOS update 12.1 no longer blocking any of previous blocked elements on ALL of those sites. I have tried over a dozen that were previously blocked elements and even redoing them and refreshing the pages does not "stick." So .. element blocking over all is now broken.

Expected Behavior

Actual Behavior

Screenshots

Screenshot:

Additional Information

avincent98144 commented 2 years ago

MacOS update 12.1 no longer blocking any of previous blocked elements on ALL of those sites. I have tried over a dozen that were previously blocked elements and even redoing them and refreshing the pages does not "stick." So .. element blocking over all is now broken.

avincent98144 commented 2 years ago

MacOS update 12.1 no longer blocking any of previous blocked elements on ALL of those sites. I have tried over a dozen that were previously blocked elements and even redoing them and refreshing the pages does not "stick." So .. element blocking over all is now broken.

avincent98144 commented 2 years ago

MacOS update 12.1 no longer blocking any of previous blocked elements on ALL of those sites. I have tried over a dozen that were previously blocked elements and even redoing them and refreshing the pages does not "stick." So .. element blocking over all is now broken.

Birbber commented 2 years ago

@avincent98144 Please try to disable all the content blockers and re-enable them again. Sometimes the situation you described might happen after the update. Let us know the result.

avincent98144 commented 2 years ago

I did that a couple times already, even a reboot. same issue.

On Dec 14, 2021, at 6:12 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Please try to disable all the content blockers and re-enable them again. Sometimes the situation you described might happen after the update. Let us know the result.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-993581243, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD6MCLMRCNXTMF7ZIP3UQ5GDLANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

avincent98144 commented 2 years ago

I even enabled ONLY Adguard. Same issue.

On Dec 14, 2021, at 6:12 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Please try to disable all the content blockers and re-enable them again. Sometimes the situation you described might happen after the update. Let us know the result.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-993581243, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD6MCLMRCNXTMF7ZIP3UQ5GDLANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Birbber commented 2 years ago

@avincent98144 Just to confirm, I was talking about these content blockers: https://uploads.adguard.com/annrgy_7vck3.png

avincent98144 commented 2 years ago

I just now did that. Issue remains.

On Dec 14, 2021, at 8:44 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Just to confirm, I was talking about these content blockers: https://uploads.adguard.com/annrgy_7vck3.png https://uploads.adguard.com/annrgy_7vck3.png Disable all of them and close Safari browser Close AdGuard for Safari Delete the following directories: ~/Library/Application Support/AdGuardSafariApp ~/Library/Containers/ - all directories started with com.adguard.safari.AdGuard (if there's any) ~/Library/GroupContainers/TC3Q7MAJXF.com.adguard.safari.AdGuard ~/Library/Preferences/com.adguard.safari.AdGuard.plist Quit all "AdGuard" and "cfprefsd" processes in Activity monitor Reinstall AdGuard for Safari — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-993745049, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD2R3UHNHS5O7DRGSP3UQ5X6JANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Birbber commented 2 years ago

@avincent98144 Blocked elements are still shown even after clearing site data, is that correct?

avincent98144 commented 2 years ago

That is correct. I have since discovered that a few of the over 100 customized sites seem to have not been affected.

However, the majority were back to un customized and when I apply those custom changes to the elements again - they do not “stick” thru a page refresh or even browser restart.

On Dec 15, 2021, at 2:04 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Blocked elements are still shown even after clearing site data, is that correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-994614872, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD2IF5RMRBCY67EZNX3URBR2RANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Birbber commented 2 years ago

@avincent98144 Could you send us the debug logs? Here's what we need you to do:

avincent98144 commented 2 years ago

Github is returning the emails, saying the log ZIP attachment is too large!

On Dec 17, 2021, at 12:30 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Could you send us the debug logs? Here's what we need you to do:

Make sure all Safari content blockers are enabled; Reproduce the issue and remember the exact time when it happened; Open the extension settings --> Export logs and system info; Send the archive to @. @.> and mention this issue number in the subject. — Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-996529913, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD4KNAHKWJNLVSGWT2DURLYKVANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

avincent98144 commented 2 years ago

The body of that undeliverable email:

This is a system-generated message to inform you that your email could not be delivered to one or more recipients. Details of the email and the error are as follows:

@. @.>>: message size 8523546 exceeds size limit 5120000 of server in-7.smtp.github.com http://in-7.smtp.github.com/[140.82.114.31] Reporting-MTA: dns; pv50p00im-ztdg10022001.me.com http://pv50p00im-ztdg10022001.me.com/ X-Postfix-Queue-ID: 93E2DA0516 X-Postfix-Sender: rfc822; @. @.> Arrival-Date: Sat, 18 Dec 2021 14:35:20 +0000 (UTC)

Final-Recipient: rfc822; ****@**** Original-Recipient: @. @.> Action: failed Status: 5.3.4 Diagnostic-Code: X-Postfix; message size 8523546 exceeds size limit 5120000 of server in-7.smtp.github.com http://in-7.smtp.github.com/[140.82.114.31] Return-Path: @. @.>> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com http://me.com/; s=1a1hai; t=1639838142; bh=vvKD+HkpTCBQPgPFUF+G6sCPmM4tUjX0OXOYu3NYppg=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=0YtShRWhrtmFRBgf+DOT+JtDRQQ+EWMoqNEOMLq6it7rzzSzF8vEJqE6AYh6PvgSM T6O1tg2J6zwplQDNwMMVIfVjFmVQT75NZZ9eoVPd/BpgRbubxP8p+tqBNoxhzSPma+ q86Ihmd8+7IxGYDredR+r/srJ38w/d/CUMAZvzWM11KCer6ZX6+6l9haB2tnXMpUgN on2pjjTTVvCLbVOI6oG/ZRroTgaABbef0tq0Fdew83B22t8H4neJL5r+GJ6rJFPrR7 a40YEKIlWu2oXN4hXbVi50/ywK4vIhIoNKidGa/bid5kTNX0wnu7DgnxIR1OJRNu6S t3Hg0dVrQibbg== Received: from smtpclient.apple (c-24-22-182-210.hsd1.wa.comcast.net http://c-24-22-182-210.hsd1.wa.comcast.net/ [24.22.182.210]) by pv50p00im-ztdg10022001.me.com http://pv50p00im-ztdg10022001.me.com/ (Postfix) with ESMTPS id 93E2DA0516 for @. @.>>; Sat, 18 Dec 2021 14:35:20 +0000 (UTC) From: Anthony Vincent @. @.>> Content-Type: multipart/alternative; boundary="Apple-Mail=_DC4A3201-25E9-43B5-9E73-FCB417F43A80" Mime-Version: 1.0 (Mac OS X Mail 15.0 (3693.40.0.1.81)) Subject: Re: [AdguardTeam/AdGuardForSafari] MacOS update 12.1 no longer blocking any of previous blocked elements on ALL of those sites (Issue #672) Date: Sat, 18 Dec 2021 06:35:19 -0800 References: @. @.>> @. @.>> To: AdguardTeam/AdGuardForSafari @. @.>> In-Reply-To: @. @.>> Message-Id: @. @.>> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-12-17_06:2021-12-15,2021-12-17 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=parse_limit adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2112180087

On Dec 17, 2021, at 12:30 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Could you send us the debug logs? Here's what we need you to do:

Make sure all Safari content blockers are enabled; Reproduce the issue and remember the exact time when it happened; Open the extension settings --> Export logs and system info; Send the archive to @. @.> and mention this issue number in the subject. — Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-996529913, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD4KNAHKWJNLVSGWT2DURLYKVANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

Birbber commented 2 years ago

@avincent98144 Try using another mailbox to send us the logs.

avincent98144 commented 2 years ago

I tried that!

I have since discovered that the issue now intermittent: either they all do not work customized, then, even with out a reboot, they are all of a sudden customized.

The files are over 27MB total

Please advise.

On Dec 20, 2021, at 12:27 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Try using another mailbox to send us the logs.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-997702279, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD6SE3CM4NQOVSHXHUDUR3SG7ANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

Birbber commented 2 years ago

@avincent98144 Really weird. Maybe you could upload it on Google Drive or anything like that and give us a link? Logs would be really helpful in this case. We've passed the details to our devs.

avincent98144 commented 2 years ago

Link to iCloud files of LOGS: https://www.icloud.com/iclouddrive/078NR9tJB4DappatDTkfBs-pA#Adguard

On Dec 22, 2021, at 2:08 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 Really weird. Maybe you could upload it on Google Drive or anything like that and give us a link? Logs would be really helpful in this case. We've passed the details to our devs.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-999449449, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD6HCNEWYEKBDFUVDLTUSGPRPANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

Birbber commented 2 years ago

Thanks, our devs will look at this.

avincent98144 commented 2 years ago

It just occurred to me .. there are 2 Adguard extensions in use, see screenshots. I’ve always wondered why.

On Dec 22, 2021, at 6:40 AM, Anna @.***> wrote:

Thanks, our devs will look at this.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-999625430, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD4OCSIJ6MH662DB253USHPNPANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

Birbber commented 2 years ago

What screenshots are you referring to?

avincent98144 commented 2 years ago

Uh .. these .. which were sent.

On Dec 22, 2021, at 11:29 PM, Anna @.***> wrote:

What screenshots are you referring to?

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-1000101292, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD3QABRYNWLKHX5GHMLUSLFXNANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

Birbber commented 2 years ago

@avincent98144 You've sent the logs only, no screenshots were there. As I can see, you use both AdGuard for Safari and AdGuard desktop application. Maybe in your case it's better to use AdGuard desktop only and delete AdGuard for Safari.

avincent98144 commented 2 years ago

I have tried using one or the other. The issue still exists. This is new since the 12.1 update and Safari Tech Preview 136 and now 137].

On Dec 23, 2021, at 7:30 AM, Anna @.***> wrote:

@avincent98144 https://github.com/avincent98144 You've sent the logs only, no screenshots were there. As I can see you use both AdGuard for Safari and AdGuard desktop application. Maybe in your case it's better to use AdGuard desktop only and delete AdGuard for Safari.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/672#issuecomment-1000378123, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRHFD3WNKB4ZPFGL5IGS7LUSM6ARANCNFSM5KA6UG2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

Birbber commented 2 years ago

Will take a deep look into this. Thanks for the report.

Birbber commented 2 years ago

@avincent98144 As for the AdGuard desktop application, according to the logs there's nothing wrong with the application work. Developers suggested to delete beta versions of AdGuard scripts. Like this one, for example: https://userscripts.adtidy.org/beta/assistant/4.3/assistant.user.js. It might help to reset your settings by clicking 'Advanced --> Reset settings': https://uploads.adguard.com/annrgy_bw3wj.png As for the AdGuard for Safari -- still waiting for devs to take a look into the logs. Will let you know once we got any information on this matter.