AdguardTeam / AdGuardForSafari

AdGuard for Safari app extension
GNU General Public License v3.0
1.05k stars 74 forks source link

Youtube adverts on Ventura OS #771

Open HorstKlein67 opened 1 year ago

HorstKlein67 commented 1 year ago

Latest Version of Adguard on latest Safari and MacOS

open youtube select a movie with ads before the movie instead of skipping the ads like in earlier versions, a white screen will appear with a waiting timer after that you have to manually skip the "white ad" or a little text banner with a company name

before upgrading to Ventura, the ad blocking on Youtube worked find.

Versty commented 1 year ago

@HorstKlein67 Hi! We tried to reproduce this issue in the same environment, but YouTube filtering works just fine on our side. Perhaps something went wrong during the MacOS update. Clean installation should fix this issue. Please, follow the steps below to completely uninstall AdGuard for Safari:

  1. Uncheck all AdGuard for Safari extensions in Safari -> Preferences -> Extensions (if available)
  2. Open Finder and press Shift+Command+G
    • Remove AdGuardSafariApp folder from ~/Library/Application Support directory
    • Remove from ~/Library/Application Scripts - all directories started with com.adguard.safari
    • Remove from ~/Library/Containers - all directories started with AdGuard-
    • Remove TC3Q7MAJXF.com.adguard.safari.AdGuard folder from ~/Library/GroupContainers directory
    • Remove com.adguard.safari.AdGuard.plist from ~/Library/Preferences
  3. Open Activity Monitor and force quit all "cfprefsd" processes
  4. Remove AdGuard for Safari from Applications

Then download and install AdGuard for Safari again.

HorstKlein67 commented 1 year ago

Hello,

i did all the above and my tests are inconsistent. After the new installation the described behavior happened again once or twice. But since I try to make a screen recording of the "Bug", I can not reproduce it anymore. So it's working fine at this very moment, but I continue keeping an eye on it.

Thanks for the suggestion with deletion and new installation. BTW: I did not find the AdGuardSafariApp folder from ~/Library/Application Support directory

Thank you.

Versty commented 1 year ago

@HorstKlein67 Weird behaviour. Please inform me and reopen this thread if the issue will be reproduced consistently again.

HorstKlein67 commented 1 year ago

I was able to reproduce the issue and make a video: The Video I started was: https://www.youtube.com/watch?v=ZfwDHhAks80

And the video what happened is here on YouTube: https://www.youtube.com/watch?v=uUsSgf6-Z10

I can reproduce it, but in only happens when I watch a movie from this channel for the first time. When I stop and restart, it is working fine or when I start another video from this channel there is also no problem.

It's not a drama, but I've never seen this behaviour before Ventura.

tvinzz commented 1 year ago

@HorstKlein67, please reproduce issue, export logs after it and send to the apple@adguard.com, add issue number to the letter subject.

HorstKlein67 commented 1 year ago

logs here


Von: tvinzz @.> Gesendet: Mittwoch, 7. Dezember 2022 10:51 An: AdguardTeam/AdGuardForSafari @.> Cc: HorstKlein67 @.>; Mention @.> Betreff: Re: [AdguardTeam/AdGuardForSafari] Ad blocking you youtube in Safari under Ventura is not working anymore (Issue #771)

@HorstKlein67https://github.com/HorstKlein67, please reproduce issue, export logs after it and attach here.

— Reply to this email directly, view it on GitHubhttps://github.com/AdguardTeam/AdGuardForSafari/issues/771#issuecomment-1340674957, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AODU5KLLJD4WD5Z465IRJRLWMBMYNANCNFSM6AAAAAASTIAMGI. You are receiving this because you were mentioned.Message ID: @.***>

git-anish commented 1 year ago

Issue Details

Expected Behavior

Blocked youtube ads and video playing

Actual Behavior

Youtube ad not playing or skipping, normal video not playing at all

^ comment posted by @HorstKlein67 is a good representation of the issue its basically the same as what I am experiencing albeit in my case the video usually never ends up playing. I have to restart the tab repeatedly until the ad is blocked.

Screenshots

link

Additional Information

Already followed instructions laid out here earlier by @Versty - still this issue, will forward logs with verbose logging to apple@adguard.com

Versty commented 1 year ago

@git-anish Hi! Thank you for the detailed description! Your logs have been received. In fact, you are using lots of other extensions, they may interfere with AdGuard for Safari in this case. Could you temporarily disable all of them in the Safari setting (Safari -> Settings -> Extensions -> uncheck every extension box except for AdGuard for Safari), then relaunch Safari and check if the ads are blocked on YouTube?

git-anish commented 1 year ago

Hi,

since posting the earlier message I tried doing exactly that, the issue persists. I also sent the detailed logs requested via email, please let me know if you need additional logs the issue doesn't happen a lot it may happen once a day or so. Thats why its hard to get you more logs.

git-anish commented 1 year ago

Hi @Versty I've sent a follow up email attaching multiple screenshots showing AdGuard as the only active extension and two logs of this issue occurring twice in a row.

I hope this helps clarify this issue is happening specifically with AdGuard and not due to conflicts with other extensions.

Thank you

Versty commented 1 year ago

@git-anish Thank you for the additional logs. Could you disable AdGuard Experimental filter and keep an eye on the issue? It contains some experimental rules related to Youtube ads and may be the cause.

git-anish commented 1 year ago

Hi @Versty are experimental filters not required to block all youtube ads? it’s the only reason that I have experimental filters turned on.

Versty commented 1 year ago

@git-anish All Youtube ads should be successfully blocked with AdGuard Base filter. So, no need to use experimental filter.

git-anish commented 1 year ago

@Versty can confirm even turning off the experimental filter has not helped, attached logs via email for two separate instances of the same issue after this change.

nsklaus commented 1 year ago

here, often times when i open a youtube link, when the page finishes loading up, the video still image shown (the image you see before you press 'play' button) is the image taken from the ad. if i press 'play', the video does not start, it keeps on trying to start it forever. i have to reload the whole page until the still image shown is the one from the video and not from the ad. sometimes i have to reload the page 2-3 times before i can finally see the video.

so for me while technically i can say ads are blocked and never play, there's still annoyances: the still image shown is wrong, and page needs a few reloads.

i'm using macos ventura 13.2 on an m1 13" macbookpro, safari 16.3 (18614.4.6.1.5) and AdGuard for Safari Version 1.11.10

Versty commented 1 year ago

@nsklaus Hi! Thank you for the detailed description. Do you have any other Safari extensions installed?

nsklaus commented 1 year ago

@Versty hi, i had dark reader, maybe iina too, and the various adguard ones. i have switched back to using brave browser at the moment, but if you need me to do some tests, it is possible.

RJKflyer commented 1 year ago

I too have this issue - YouTube videos load WITH an Ad shown, but with a rotating circle which prevents the Ad from playing.

Reloading the YT window MAY result in the Ad being suppressed, but MAY be required multiple times until Ad is suppressed.

NO other extensions running.

Logs attached: The logs have been removed to protect you personal data

Versty commented 1 year ago

@RJKflyer Thanks, your logs have been saved and removed from the comment. Are you using macOS Ventura either?

RJKflyer commented 1 year ago

Yes, 13.2.1 Best regards

Richard J Kelly

On 20 Feb 2023, at 09:05, Diana @.***> wrote:

@RJKflyer https://github.com/RJKflyer Thanks, your logs have been saved and removed from the comment. Are you using macOS Ventura either?

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/771#issuecomment-1436584431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVNF7NFRLK4XF5RW5XNKYLWYMXXBANCNFSM6AAAAAASTIAMGI. You are receiving this because you were mentioned.

git-anish commented 1 year ago

hi any updates on this issue @Versty ?

Versty commented 1 year ago

@git-anish Please update to the latest AdGuard for Safari 1.11.12. Does the issue persist?

nsklaus commented 1 year ago

i've just updated to adGuard for Safari 1.11.12, restarted both adguard and safari. from my rss app, i have many subscriptions to some youtube channels, i clicked 3 of them. they opened each in a new safari tab, out of the 3, two of them were correct. the third one showed the same problem as described here. video stuck on still image belonging to the ad instead of the actual video. as such video would not start, and the spinning circle would go on forever. this wasn't extensive testing. but i would say yes, the issue does persist.

Versty commented 1 year ago

@nsklaus Thank you for testing. We continue to work on this issue further.

git-anish commented 1 year ago

@Versty yes

RJKflyer commented 1 year ago

Now on OS 13.3.1 and Safari 16.4 and YouTube ads are NOT filtered on first view of almost any YT video. The Ad appears and a white rotating circle in the centre.

Reloading the page removed the Ad correctly.

Is this bug being progressed?

Versty commented 1 year ago

@RJKflyer Yes, this issue is in progress.

HensTeeth commented 1 year ago

Youtube adverts incorrectly filtered #801 was closed with the suggestion to comment here if it's still an issue. The problem has become steadily worse to the point where I have to use Chrome instead. I'd prefer not to use Chrome, but uBlock Origin plus Chrome equals ad-free YouTube...

Versty commented 1 year ago

@HorstKlein67 @RJKflyer @HensTeeth @git-anish We have made some adjustments to the filters, please update the filters and check if the issue is gone.

RJKflyer commented 1 year ago

Still present for me. Best regards

Richard J Kelly

On 6 Jul 2023, at 16:18, Diana @.***> wrote:

@HorstKlein67 https://github.com/HorstKlein67 @RJKflyer https://github.com/RJKflyer @HensTeeth https://github.com/HensTeeth We have made some adjustments to the filters, please check if the issue is gone.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdGuardForSafari/issues/771#issuecomment-1623865348, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVNF7NKBA7YZIXEPTWIPLLXO3JLVANCNFSM6AAAAAASTIAMGI. You are receiving this because you were mentioned.

HensTeeth commented 1 year ago

Issue still present for me too.

Versty commented 11 months ago

@HensTeeth @RJKflyer Please check this issue with AdGuard for Safari 1.11.16. In this version we have adjusted our scriptlets library to work properly on Youtube.