[Feature Request] Enable/Disable Logs For Specific Clients Or Client Groups

ghost commented 4 years ago

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

[X] I am running the latest version
[ ] I checked the documentation and found no answer
[ ] I checked to make sure that this issue has not already been filed

Problem Description

I use AdGuard Home through my router, I have it setup with parental controls for my sister and tracking/ad blocking for me. But, my dad doesn't want his stuff being logged or filtered and I don't want to see it because it's not important to me. I only check logs for seeing if my sisters stuff is being blocked correctly or blocking ads in Windows apps.

Proposed Solution

Add a button in the Client Settings to enable/disable logs for the selected client

ghost commented 4 years ago

Unfortunately, I dont like about disable logs for specific clients feature, instead we can consider about middle ground solution with additional enhancement https://github.com/AdguardTeam/AdGuardHome/issues/916 (remove client IP addresses from logs) while enable/disable logs feature already exist.

ameshkov commented 4 years ago

Well, it's either #916 or this, I guess we should choose.

ghost commented 4 years ago

My request was mostly to do with parental controls and my dad just wanting to see what my sister is doing (he doesn't approve of things like Snapchat and refuses to let her get it) and he wants to make sure it's blocked and she didn't find a way around it. He's always not allowed most social media because he doesn't want his stuff being tracked because of one of us. I had told him this also works as a network wide ad/tracking blocker and so now we use it in the router but he doesn't want to see his own stuff or even mine, just my little sister's.

I don't know if that changes anything but another request could be to make it so we can search by client groups instead of having to use a bunch of different IP addresses.

ghost commented 4 years ago

Just a comment....

But, my dad doesn't want his stuff being logged or filtered and I don't want to see it because it's not important to me. but he doesn't want to see his own stuff or even mine, just my little sister's. he doesn't want his stuff being tracked because of one of us. and he wants to make sure it's blocked and she didn't find a way around it. My request was mostly to do with parental controls and my dad just wanting to see what my sister is doing (he doesn't approve of things like Snapchat and refuses to let her get it) I only check logs for seeing if my sisters stuff is being blocked correctly or blocking ads in Windows apps.

I think below features may fulfill those most things you described. It seems hand over super administrator access to your father might be also better while you get limited access for necessary devices under custom permissions. (however it doesn't prevent you to hold an administrator account or manage any other devices)

https://github.com/AdguardTeam/AdGuardHome/issues/997 User Accounts
https://github.com/AdguardTeam/AdGuardHome/issues/1245 Roles & Permissions (doubt if that implement)

Enable/disable logs for the selected client does not guarantee that you can't re-enable it, I believe he dont want to trust you 😄

another request could be to make it so we can search by client groups instead of having to use a bunch of different IP addresses.

https://github.com/AdguardTeam/AdGuardHome/issues/1273

ghost commented 4 years ago

@ArchiveBase I actually do think that stuff is better than what I was proposing. Thanks!

@ameshkov With what ArchiveBase has shown I believe it's best to go with #916 instead of what I was proposing. Issues #997 #1245 and #1273 would do all that I needed. I believe that it's more important for people using AdGuard Home as a open resolver to have the option to anonymize or remove client IP's.

Justin991q commented 4 years ago

It would be nice to disable logging for a client, since I have a lot of "spam" requests from Home-Assistant which makes the query logs unreadable.

An option like this would be nice:

ghost commented 4 years ago

It would be nice to disable logging for a client, since I have a lot of "spam" requests from Home-Assistant which makes the query logs unreadable.

Just no too despite about disable logging for one or several clients but then you will never know what happening on that device or about any malicious traffic receive to your network. Also possible for someone to take advantage with such built in features to bypass as well. I forgot mention here about log filtering options; that will fulfill you needs https://github.com/AdguardTeam/AdGuardHome/issues/481

Justin991q commented 4 years ago

It would be nice to disable logging for a client, since I have a lot of "spam" requests from Home-Assistant which makes the query logs unreadable.

Just no too despite about disable logging for one or several clients but then you will never know what happening on that device or about any malicious traffic receive to your network. Also possible for someone to take advantage with such built in features to bypass as well. I forgot mention here about log filtering options; that will fulfill you needs #481

What about an option to hide it from the query log by default? And if you want to see it you can just filter on that client.

But I think that has something to do with #481

ghost commented 4 years ago

What about an option to hide it from the query log by default? And if you want to see it you can just filter on that client.

But I think that has something to do with #481

That also good idea.

ameshkov commented 4 years ago

@Justin991q please don't forget to upvote the original feature request (add an upvote emoji), we keep an eye on the most upvoted

ghost commented 4 years ago

Duplicate #767 @ameshkov suggest to close #767 instead.

vipinjn24 commented 3 years ago

this should be there, if we are deploying it on kubernetes with liveness probe with lookup command to ensure liveness then it is required, it is flooding the logs.

ihipop commented 2 years ago

any update on this issue?

dynosu commented 1 year ago

Would like this issue to prevent health checks from coming up. Another option is to point 1 specific address as a health check which doesnt show up by default. This would be a real domain, and should resolve, but wouldnt show up in logs.

felipecrs commented 1 year ago

I have the exact same issue thanks to my Unifi switch:

dynosu commented 1 year ago

I have the exact same issue thanks to my Unifi switch:

Yes, i have that with the health check from my dnsdist. I need it to work or need another way to check for dnsdist if resolving still works.

FinlayDaG33k commented 7 months ago

The feature would still be very much appreciated.
Landline phone kinda driving me nuts.

afbeelding

AdguardTeam / AdGuardHome