Open DandelionSprout opened 4 years ago
The same issue, I use a Let's Encrypt Authority X3 Cert, as we know it only has 3 months valid time, and I choose acme.sh to issued cert (it will renew every 60 days by default). Obviously, AGH reminds 30 days before the expiration date. In my opinion, the notice time can be modified in the configuration file will make more sense.
I have a similar problem..., I've had this warning since the 1 month to go mark, however when my certificate was automatically renewed the warning did not go away. So, I still have this warning banner today, 2020-07-14 and my certificate does not expire until 2020-10-07 (AdGuard Home Version: v0.102.0)
However..., the date information reported on the AdGuard Dashboard page does not match the info displayed when looking at the certificate in chrome:
Here the expiry is listed as 2020-08-08, in which case the warning would be valid (but still annoying....). So it looks like one of these two pages is reading the certificate validity end date incorrectly....
In version v0.105 we reduced the threshold to 5 days before expiration.
If you see the notification earlier than that, please let me know.
Also, please do two things:
new Date()
in the browser consoleSame issue here. Warning triggered five days before the last certificate would have expired. But the new certificate, valid until July, is correctly displayed in Encryption Settings. new Date() output is correct.
After two days ignoring it, I simply hit save configuration in Encryption Settings and the warning was gone. At least for now.
In version v0.105 we reduced the threshold to 5 days before expiration.
Please allow users to configure this threshold in the settings. Possibly a "day" select with 0 disabling the alert? For Home Lab environments this can be a tad annoying.
Not to mention ACME providers like step-ca advocate for use of short-lived certificates for security purposes. For now I'll use CSS.
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
The SSL certificate expiration warning begins to show up a full month before the certificate was to expire (in my case the 9th of March), which can be pretty problematic when using an ASUSCOMM-administered certificate which only lasts 3 months before they allegedly get renewed upon or very close to expiry.
There's also no way to close the banner, apart from using
##.topline.alert-warning.alert
, which may or may not block other kinds of warnings as well.Proposed Solution
Make it possible to adjust the amount of days remaining until expiration before the SSL warning begins to show up.
Alternatives Considered
Add a close button to the warning(s).
Additional Information
I wouldn't be surprised if my use of a __.asuscomm.com SSH certificate as my HTTPS certificate in my AGH settings, would be considered technically questionable. But they're free of charge, are included and very easy to set up in modern ASUS routers, and does not seem to cause any visible breakage apart from not supporting client connections from IPv6 IPs.