AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home/overview.html
GNU General Public License v3.0
25.77k stars 1.85k forks source link

DHCP and multiple interfaces #3539

Open ainar-g opened 3 years ago

ainar-g commented 3 years ago

Currently, we only allow users to select one interface on which AGH serves DHCP. That model doesn't quite work when you have e.g. a router that also has some machines connected to it over WAN.

We could either allow multiple DHCP setting sets or maybe add a new pseudointerface value like “Serve on all interfaces”.

Either way, this may complicate some other parts of the logic, for example the selection of the gateway IP address and IP ranges.

@ameshkov, please tell us what you think.

ameshkov commented 3 years ago

Our DHCP server is supposed to be really simple and covering cases like that seems to be out of scope, at least at this point.

ainar-g commented 3 years ago

@ameshkov, we already have a couple of issues where people mention that their WLAN+WAN setups don't work correctly. See, for example, #3366, #3480, and possibly #3462. The previous versions sometimes work, because they implemented the RFCs a bit incorrectly on some OSes. We will try to restore the old “incorrect” behaviour in v0.107.0, but this problem will remain an issue for us unless we either solve this on AGH's level or come up with several sets of workarounds for every supported OS (e.g. virtual interfaces and such).

ainar-g commented 3 years ago

We'll probably return to this question after v0.107.0 is out and the refactoring of v0.108.0 will look good enough.

Azureit commented 3 years ago

I was about to request this. I have a router erlite with WAN+2LAN, and each LAN needs a dhcp server.

EDIT: The http bind_host should be multiple, like the dns bind_hosts

tescophil commented 2 years ago

Would also like to see this, I have a setup with 6 internal VLANs and I would like to get AGH to serve DHCP across all of them...

kiwilad-nz commented 2 years ago

+1 on this feature.

ainar-g commented 2 years ago

Please refrain from comments like “+1”. A :+1: emoji on the top comment is enough. Thanks.

IllicLanthresh commented 1 year ago

Has there been any progress on this issue yet? I'm also in need to serve DHCP leases to multiple vlans/subnets

cank79 commented 1 year ago

+1

ajtatum commented 1 year ago

I honestly don't know how requests for this feature from almost 4 years ago have still not been implemented. Does AdGuard not understand the importance of being able to handle this? Just seems to be falling on deaf ears...

sigarcher commented 6 months ago

hi, is this feature coming soon, is it on the roadmap?

alexindigo commented 1 month ago

With proliferation of "homelab"/"self hosted" setups, multi-VLAN is becoming more common, so support for multiple interfaces is something that will be issue for manny potential users.