search

AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
25.07k stars 1.8k forks source link

DNS requests blocked by upstream servers should not be marked Processed #3733

Open wanam opened 3 years ago

wanam commented 3 years ago

Problem Description

Currently DNS requests blocked by upstream servers are marked "Processed". Example: blocked_by_upstream

Proposed Solution

DNS requests blocked by upstream servers should be marked "Blocked" or maybe "Blocked by upstream". Based on the null response "0.0.0.0" of the upstream server, I think it's easy to discriminate those requests.

ainar-g commented 3 years ago

I don't think that we can generally assume that 0.0.0.0 definitely means that the domain is blocked, since it could also be an upstream server misconfiguration. Besides, upstream servers could block domains using other means, such as an empty answer section or a REFUSED response code.

@ameshkov, what do you think?

ameshkov commented 3 years ago

Well, generally this sounds like a good idea. We did in fact encountered many questions from people using upstream DNS servers with filtering and they didn't realize that their upstreams do that.