AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
25.08k stars 1.8k forks source link

Query Log: Entries "Blocked" but really just redirected #3926

Open sidbena opened 2 years ago

sidbena commented 2 years ago

Prerequisites

Issue Details

Expected Behavior

Entries should be marked as Redirected or /etc/hosts style redirect, or something more indicative of not explicitly being Blocked in Query Log.

Actual Behavior

Entries in Query Log end up Blocked when they're configured to be managed/redirected by an /etc/hosts style entry in Custom filtering rules.

Screenshots

adguard-querylog

EugeneOne1 commented 2 years ago

@sidbena, hello and thanks for the report! The proposed improvement actualy makes sense. @ameshkov, what would we prefer to see instead?

ameshkov commented 2 years ago

Not sure about that. There are many blocklists in the HOSTS format, and they're supposed to block things, even though technically speaking this is a redirect.

ainar-g commented 2 years ago

There'll be some changes in how we do query logs in v0.108, so we'll see what we'll be able to do with new storages.

tekand commented 2 years ago

For some reason under v0.107.2 for me it really blocks it, does not redirect.

image

Was this behaviour updated recently?

Maybe because I used a blocklist instead of the custom filtering rules? I thought it will work based on https://github.com/AdguardTeam/AdGuardHome/wiki/Hosts-Blocklists#rules-examples