AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
25.09k stars 1.8k forks source link

Show all filtering rule lists in the filter checker #4028

Open gyCfjSnO opened 2 years ago

gyCfjSnO commented 2 years ago

Issue Details

Expected Behavior

Searching a domain on the Custom Filtering Rules page under Check the filtering should show all lists which contain the domain searched.

Actual Behavior

When searching a domain (which is on more than one Blocklist) on the Custom Filtering Rules page under Check the filtering only returns one result.

Screenshots

Screenshot: ![Screenshot_20211228-130328](https://user-images.githubusercontent.com/49738152/147523509-a83ab9da-d410-4834-a1e7-2f5c7edd0c78.png)

Additional Information

ainar-g commented 2 years ago

Related: #3452.

I'm not entirely sure if our filtering library allows us to do that, but we'll investigate.

gyCfjSnO commented 2 years ago

Related: #3452.

I'm not entirely sure if our filtering library allows us to do that, but we'll investigate.

How does it determine which list to reply back with showing it is on the blocklist?

two-dogs commented 2 years ago

Related: #3452.

I'm not entirely sure if our filtering library allows us to do that, but we'll investigate.

How does it determine which list to reply back with showing it is on the blocklist?

If the issue is 'do i have the rule duplicated or not found across multiple rule lists, then show which list/s' is not an option, i am also wanting the option to see where, i assume a 'not found' now means across all lists enabled.

ainar-g commented 2 years ago

@gyCfjSnO

How does it determine which list to reply back with showing it is on the blocklist?

In filter rule lists, there are priority level according to which the rules are sorted. But besides them there are also other ways of filtering queries, so all of that needs to be considered.