AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
24.99k stars 1.8k forks source link

Add an option to auto-update the upstreams list #4316

Open ameshkov opened 2 years ago

ameshkov commented 2 years ago

Apparently, this feature would be useful to the users from China since they use huge lists of upstream servers (upstream_dns_file) and would like to keep them up-to-date: https://github.com/AdguardTeam/AdGuardHome/discussions/4305

The simple solution would be to allow specifying URLs in upstream_dns_file:

upstream_dns_file: "https://example.org/upstreams.txt"

We'll also need to somehow specify the refresh time. Could be even encoded into the URL itself (refresh=5s; https://example.org/upstreams.txt).

Other ideas are welcome.

I am a bit reluctant to implement this functionality right now, let's see if it gets upvoted.

liang-hiwin commented 2 years ago

good jod

Karmylr commented 2 years ago

good job

alexeys85 commented 2 years ago

There is already the list of public servers which frequently updated. Would be great to have support it.

fernvenue commented 2 years ago

Apparently, this feature would be useful to the users from China since they use huge lists of upstream servers (upstream_dns_file) and would like to keep them up-to-date: #4305

The simple solution would be to allow specifying URLs in upstream_dns_file:

upstream_dns_file: "https://example.org/upstreams.txt"

We'll also need to somehow specify the refresh time. Could be even encoded into the URL itself (refresh=5s; https://example.org/upstreams.txt).

Other ideas are welcome.

I am a bit reluctant to implement this functionality right now, let's see if it gets upvoted.

I think this would be a very very useful feature. Just like my own project adguardhome-upstream here, you can see that we need to handle systemd/crontab, systemd/init differently in order to work properly on different operating systems. This will bring a lot of trouble to many users who do not have enough technical skills, and AdGuardHome may crash at any time if it is not configured properly.

And on the other hand, maybe you can see in my another project chn-domains-list, how frequently these list rules are updated, almost every day. All in all, if we have an option to auto-update the upstreams list, boom, problems gone.

For specifying the refresh time, I think encoding into the URL is a good option, as you already mentioned. But I think it is necessary to define some special behaviors, such as refresh=0; for never update, and no refresh is specified to take the default strategy and what the default strategy should be...and so on. My personal opinion is that the default behavior can be more than one day and less than seven days, on the one hand, this will not cause abuse for the rule hosting address, on the other hand, this frequency is appropriate for some popular rule lists like chn-domains-list mentioned above.

Actually I can quite understand why you are a little reluctant to implement this feature, it is maybe somewhat complicated and we already have a solution like upstream_dns_file right? As an AdGuardHome user, I support any decision you make, yes or no.

ZhiShengYuan commented 2 years ago

good jod

ameshkov commented 2 years ago

Please upvote the issue if you would like us to do that.

Karmylr commented 2 years ago

I just want adguard add urlfilter into AdGuardHome quicker

ameshkov commented 2 years ago

各位,请不离题。

Karmylr commented 2 years ago

LOL

liang-hiwin commented 2 years ago

expect

KeLee8 commented 1 year ago

As a user from China, I really need such a function.

Potterli20 commented 1 year ago

dns shunt file:https://github.com/Potterli20/file/releases/tag/dns-hosts This is the Chinese dns shunt file https://github.com/Potterli20/file/releases/download/dns-hosts/dns-adguardhome-blacklist_full_combine.txt This is the dns diversion file for other regions https://github.com/Potterli20/file/releases/download/dns-hosts/dns-adguardhome-whitelist_full_combine.txt

Potterli20 commented 1 year ago

已经过去一年已经过去一年

ZhiShengYuan commented 1 year ago

已经过去一年已经过去一年

As you can see, this feature is planned to be added in v0.109.0. If you can't be patient and wait, either contribute by making a pull request or shut the f**k up.

Potterli20 commented 1 year ago

已经过去一年已经过去一年

As you can see, this feature is planned to be added in v0.109.0. If you can't be patient and wait, either contribute by making a pull request or shut the f**k up.

什么什么是是什么,你在说什么?

Xwler commented 1 year ago

已经过去一年已经过去一年

As you can see, this feature is planned to be added in v0.109.0. If you can't be patient and wait, either contribute by making a pull request or shut the f**k up.

什么什么是是什么,你在说什么?

他在让你闭嘴