search

AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
23.57k stars 1.73k forks source link

Eliminate Delays between Parental Control option and Allow listing/ Custom listing (Allow listing gets immediate precedent). #4323

Open jumpsmm7 opened 2 years ago

jumpsmm7 commented 2 years ago

Hello, I am the dev for the Asuswrt Merlin Adguardhome installer, So here is my observed issue: while using parental controls ,when I allowlist a site via custom filters that is normally blocked by parental controls, it takes a while for the addition to take effect.

If I toggle the parental controls option off and on , it takes effect immediately. This is a request for immediate harmonization whenever a custom filter is added. (In the custom section) and harmonization of parental controls.

The out come would be that there is no delay (very short) delay from the time a domain is whitelisted to the time it is harmonized for example with parental controls or the rest of the filters.

Here is the conversation between several Asuswrt-Merlin users about the issue. https://www.snbforums.com/threads/release-asuswrt-merlin-adguardhome-installer-amaghi.76506/page-35#post-746827 The forum users theMorph and Somewhereovertherainbow talk about the details of the issue.

It was determined that the delay between the addition of the allow listing and the allowing of the Parental Contolled blocked site took about 30 minutes. However it is effective immediately if the user toggles the Parental Controls after allow listing a parental controlled blocked domain.

Ideally we would want this delay drastically shortened whenever a custom rule is added or a new allow list is used to ensure the Allow listings takes precedent over blocking features such as Parental Controls.

jackyaz commented 2 years ago

I'd like to point out client caches are also likely a factor in the "delay"

gspannu commented 2 years ago

+1 this is a much needed feature. observed by many users of Asus Routers running AGH

jumpsmm7 commented 2 years ago

I'd like to point out client caches are also likely a factor in the "delay" Originally posted by @jackyaz in https://github.com/AdguardTeam/AdGuardHome/issues/4323#issuecomment-1048290754

While I concur with this arguement, it does highlight the need for atleast investigation since it is remedied by the toggling of parental controls of adguardhome, which to me implies that the new list entries don't take effect until the old ones expire on adguardhome cache.

gspannu commented 2 years ago

Has this issue been investigated as suggested by jumpsmm7 above?

jumpsmm7 commented 2 years ago

@gspannu I don't think it has.