AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
25.53k stars 1.83k forks source link

Auto-update Feature Fix #4628

Closed hl2guide closed 2 years ago

hl2guide commented 2 years ago

Issue Details

Expected Behavior

Auto-update applies new version of AdGuard Home successfully.

Actual Behavior

Auto-update fails to apply and suggests a manual update.

No auto-update has succeeded for me for at least 6 versions.

Screenshots

Screenshot: ![a](https://user-images.githubusercontent.com/17044982/171971930-0f0aeb77-7763-4098-8548-6fd4d63be233.jpg) ![1](https://user-images.githubusercontent.com/17044982/171971882-d188bcf4-d116-4b05-8930-ee5221b9c204.jpg)

Additional Information

None

Disqu3-mirOir-qt commented 2 years ago

not realy complex just replace binary take 15 second

hl2guide commented 2 years ago

nope it is:

ainar-g commented 2 years ago

@hl2guide, can you please collect verbose logs of what happens when you try to update and either add attach them here or send them to devteam@adguard.com? Thanks.

hl2guide commented 2 years ago

@ainar-g will do, the next stable release will allow me to test this. I'll post then.

hl2guide commented 2 years ago

@ainar-g When trying to update from v0.107.7 to v0.107.8 I got:

2022/07/14 17:32:50.490443 4848#12 [debug] updater: saving package to file
2022/07/14 17:32:50.496603 4848#12 [debug] updater: unpacking the package
2022/07/14 17:32:50.789365 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\AdGuardHome.exe
2022/07/14 17:32:50.791514 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\AdGuardHome.exe.sig
2022/07/14 17:32:50.792625 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\LICENSE.txt
2022/07/14 17:32:50.794073 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\README.md
2022/07/14 17:32:50.795074 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\CHANGELOG.md
2022/07/14 17:32:50.795074 4848#12 [debug] updater: checking configuration
2022/07/14 17:32:51.295210 4848#12 [error] POST /control/update: exec.Command(): exit status 1 1
2022/07/14 17:32:51.463393 4848#134 [debug] github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpHandlePacket(): Start handling new UDP packet from 192.168.1.100:60071
2022/07/14 17:32:51.463393 4848#134 [debug] github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).logDNSMessage(): IN: ;; opcode: QUERY, status: NOERROR, id: 17974
;; flags: rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0
ainar-g commented 2 years ago

@hl2guide, sorry for the long silence. There have been quite a few fixes to the autoupdate function recently. Do you still experience the issues?

hl2guide commented 2 years ago

I'll test it in the next stable release.

hl2guide commented 2 years ago

Seems resolved for me, last autoupdate finally worked 😀 @ainar-g

ainar-g commented 2 years ago

Hooray! Thank you for checking! Marking as duplicate, since this seems to have been caused by some other issue that had been fixed.