Persistent client statistics don't take MAC addresses into account

dredjohn21 commented 2 years ago

Issue Details

Version of AdGuard Home server:
- v0.107.7
How did you install AdGuard Home:
- Home Assistant Add On
How did you setup DNS configuration:
- AdGuardHome DHCP is Enabled (disabled on Linksys Velop router)
If it's a router or IoT, please write device model:
- Home Assistant & AdGuardHome are running on RaspberryPi4 4GB
CPU architecture:
- Raspberry Pi 4 4GB
Operating system and version:
- HAOS (latest version)

Expected Behavior

I have added Persistent Clients with both MAC Addresses and Names, and expect to see the activity mapped to these clients on the Dashboard and also on the Persistent Clients page. I also expect to see the "Runtime Clients" list shrink as I add these items to the "Persistent Clients" section.

Actual Behavior

Instead, I only see the Dashboard show the client activity properly mapped. When I'm on the Client Settings page I don't see any "Requests" (activity) next to the Persistent Clients. I also don't see any reduction in the "Runtime Clients" list.

For example, I added my mobile phone to the Persistent Clients list with my phone's MAC Address. I see on the Dashboard that AdGuard has properly associated the IP Address and traffic with my MAC Address. However, on the Persistent Client's list there is no activity reflected on the right column under 'Requests'. And at the bottom under "Runtime Clients" I still see my mobile phone listed with activity showing up under 'Requests'.

What is odd is if I add my mobile phone's IP Address to the Persistent Client setting then the "Request" data will show up properly, but it will still not remove the device from the "Runtime Client" section.

It seems like the logic to map the values is not working properly on this "Client Settings" screen. Ideally the logic should mirror what is used on the Dashboard, and as devices get added to "Persistent Clients" they should be removed from the "Runtime Client" section.

Screenshots

Screenshot:

Additional Information

ainar-g commented 2 years ago

Hello. We had an issue about it, but I can't seem to find it now. Basically, the statistics are currently only collected by clients' IP addresses, not MAC addresses or some other IDs. We'll try to fix that during the v0.108 cycle.

dredjohn21 commented 2 years ago

Hello. We had an issue about it, but I can't seem to find it now. Basically, the statistics are currently only collected by clients' IP addresses, not MAC addresses or some other IDs. We'll try to fix that during the v0.108 cycle.

Cool thank you!!

35314u commented 3 weeks ago

When will the problem be solved? Some time has passed since the last entry here and the problem still exists.

AdguardTeam / AdGuardHome