AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
25.44k stars 1.83k forks source link

Local Filtering tests will not expand #4703

Open erdoukki opened 2 years ago

erdoukki commented 2 years ago

Issue Details

Expected Behavior

When testing local filter, I would have get the answer about blocking status been more relevant.

Actual Behavior

When domain is checked in local filter status, if the domain is expandable (redirected) then the tests will only check the given text. It will not go through all different expandable possibles. It make difficult to find the status and the list. Only the Logs give the information.

Screenshots

Screenshot: ![Capture d’écran du 2022-06-30 10-15-44](https://user-images.githubusercontent.com/2179472/176630791-5b99d77a-4330-4d94-90ad-8b850260a8d6.png) ![Screenshot 2022-06-30 at 10-27-26 AdGuard Home](https://user-images.githubusercontent.com/2179472/176630461-685c6890-6588-4a6f-8893-a14043340177.png)

Additional Information

Issue already reported in a filtering list which make me have the issue

https://github.com/alexsannikov/adguardhome-filters/issues/7

THX

EugeneOne1 commented 2 years ago

@erdoukki, hello, and thanks for the report. I'd say it's an expected behavior. The thing is the real request is blocked because of aushafeeds.b-cdn.net. canonical name in the response, which matches the rule. However, there are no DNS requests performed during the filtering check so there is no way to tell if the real request will be blocked until you made it yourself.

Actually, we already have a feature request (#4036) about enhancing the filtering check, so I think we can deal with performing the real request in the improved implementation.

erdoukki commented 2 years ago

Sure, it will be great to enhance the test for a dns like call. Thanks for feedback.