Support to select DNS upstreams randomly or by round-robin

AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server

https://adguard.com/adguard-home.html

GNU General Public License v3.0

24.9k stars 1.79k forks source link

Support to select DNS upstreams randomly or by round-robin #4751

Open PeterDaveHello opened 2 years ago

PeterDaveHello commented 2 years ago

Prerequisites

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

Feature Description

Allow AdGuard to select upstream DNS servers randomly(not weighted)

Proposed Solution

Add another strategy option besides current load-balancing, parallel requests and fastest IP address.

Additional Information

That's something supported in dnscrypt-proxy and blocky, not sure if you'd also consider to support it in AdGuard Home? Thanks ;)

fonic commented 1 year ago

I second this. Random or round-robin would be a really nice feature in terms of privacy. Also, the current weighted approach often results in a single fast provider in the list being used for almost all requests.

hnry commented 11 months ago

I second this. Random or round-robin would be a really nice feature in terms of privacy. Also, the current weighted approach often results in a single fast provider in the list being used for almost all requests.

I'm glad someone pointed this out. This isn't what I expected a weighted load balance to do. It completely favors a single upstream (we're talking 99%+). See https://github.com/AdguardTeam/AdGuardHome/discussions/6361 , https://github.com/AdguardTeam/AdGuardHome/issues/3521

fonic commented 10 months ago

I'm glad someone pointed this out. This isn't what I expected a weighted load balance to do. It completely favors a single upstream (we're talking 99%+). See #6361 , #3521

Even worse, it seems to randomly favor a single upstream provider for a certain amount of time. With 8 providers in the list, whenever I check the dashboard, one provider is apparently being used for >98% of all request, but it's not always the same one (changes over a couple of days).

DonPablo1010 commented 8 months ago

I support this concern. An additional option with Round Robin would make Unbound unnecessary for me in the upstream. That would be great!

fonic commented 4 months ago

It would seem this has been fixed? I've been noticing that load-balancing seems to work a lot better recently.

Not sure which version and/or commit fixed this, though.