Improved Error Message for Update Checks

hl2guide commented 2 years ago

Prerequisites

[X] I have checked the Wiki and Discussions and found no answer
[X] I have searched other issues and found no duplicates
[X] I want to request a feature or enhancement and not ask a question

Description

What problem are you trying to solve?

Please improve the AdGuard Home update check failure message from:

Error: control/version.json | getting version info from https://static.adtidy.org/adguardhome/release/version.json: updater: HTTP GET https://static.adtidy.org/adguardhome/release/version.json: Get "https://static.adtidy.org/adguardhome/release/version.json": requesting https://dns.quad9.net:443/dns-query: Get "https://dns.quad9.net:443/dns-query?dns=##########": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 502

Proposed solution

something more simple like:

Update check failed, please check your internet connection is active.
Could not get version info from https://static.adtidy.org/adguardhome/release/version.json
Timeout Error (502)

ainar-g commented 1 year ago

The latest Edge version, v0.108.0-a.421+d52f1d0e, contains the improved message. Sorry it took too long.

notDavid commented 1 year ago

@ainar-g Hi there,

fyi, for some reason i'm getting the error message Update check failed. Please check your Internet connection. in the web interface since updating to the current version. Running curl https://static.adtidy.org/adguardhome/release/version.json on the same router where AdGuardHome is installed works without any issues. Also DNS resolving works just fine, so everything else is working.

AdGuard Home, version v0.107.23 (linux_mips64_softfloat.tar.gz)
Running on Ubiquiti EdgeRouter 4

ownmas commented 1 year ago

@ainar-g Hi there,

fyi, for some reason i'm getting the error message Update check failed. Please check your Internet connection. in the web interface since updating to the current version. Running curl https://static.adtidy.org/adguardhome/release/version.json on the same router where AdGuardHome is installed works without any issues. Also DNS resolving works just fine, so everything else is working.

AdGuard Home, version v0.107.23 (linux_mips64_softfloat.tar.gz)

Running on Ubiquiti EdgeRouter 4

@notDavid Same problem. Did you manage to solve this?

notDavid commented 1 year ago

@ownmas @ainar-g Nope... still happening. I think a new issue should be created for it. Everything else seems to be working though, so it's just the error message that's bugged i assume.

fridaynext commented 1 year ago

Also having the same issue on an ER4, running 0.107.23

maboxx commented 1 year ago

Is there any news in this case? Unfortunately I have the same problem on a Netgear WAX202 AP. In the web GUI the message "Update check failed. Please check your Internet connection."

In the shell with the command ./AdGuardHome --update I get the following.

2023/02/28 22:27:53.631050 [info] AdGuard Home, version v0.107.25
2023/02/28 22:27:53.831449 [info] tls: using default ciphers
2023/02/28 22:27:53.916118 [info] dnsproxy: cache: enabled, size 4096 b
2023/02/28 22:27:53.916340 [info] MaxGoroutines is set to 300
2023/02/28 22:27:53.926759 [info] cmdline update: performing update
2023/02/28 22:27:55.447648 [error] getting version info from https://static.adtidy.org/adguardhome/release/version.json: version.json: packageURL not found

But the curl command works and also any other DNS request. Everything seems good.

curl https://static.adtidy.org/adguardhome/release/version.json
{
  "version": "v0.107.25",
  "announcement": "AdGuard Home v0.107.25 is now available!",
  "announcement_url": "https://github.com/AdguardTeam/AdGuardHome/releases/tag/v0.107.25",
  "selfupdate_min_version": "0.0",

  "download_linux_armv5": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_armv5.tar.gz",
  "download_darwin_arm64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_darwin_arm64.zip",
  "download_linux_armv7": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_armv7.tar.gz",
  "download_windows_arm64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_windows_arm64.zip",
  "download_linux_mipsle_softfloat": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_mipsle_softfloat.tar.gz",
  "download_linux_amd64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_amd64.tar.gz",
  "download_linux_mips64le_softfloat": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_mips64le_softfloat.tar.gz",
  "download_linux_armv6": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_armv6.tar.gz",
  "download_freebsd_386": "https://static.adtidy.org/adguardhome/release/AdGuardHome_freebsd_386.tar.gz",
  "download_linux_mips64_softfloat": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_mips64_softfloat.tar.gz",
  "download_freebsd_armv7": "https://static.adtidy.org/adguardhome/release/AdGuardHome_freebsd_armv7.tar.gz",
  "download_freebsd_arm64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_freebsd_arm64.tar.gz",
  "download_linux_arm64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_arm64.tar.gz",
  "download_windows_amd64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_windows_amd64.zip",
  "download_linux_386": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_386.tar.gz",
  "download_linux_ppc64le": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_ppc64le.tar.gz",
  "download_windows_386": "https://static.adtidy.org/adguardhome/release/AdGuardHome_windows_386.zip",
  "download_freebsd_amd64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_freebsd_amd64.tar.gz",
  "download_openbsd_amd64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_openbsd_amd64.tar.gz",
  "download_darwin_amd64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_darwin_amd64.zip",
  "download_freebsd_armv5": "https://static.adtidy.org/adguardhome/release/AdGuardHome_freebsd_armv5.tar.gz",
  "download_freebsd_armv6": "https://static.adtidy.org/adguardhome/release/AdGuardHome_freebsd_armv6.tar.gz",
  "download_frontend": "https://static.adtidy.org/adguardhome/release/AdGuardHome_frontend.tar.gz",
  "download_openbsd_arm64": "https://static.adtidy.org/adguardhome/release/AdGuardHome_openbsd_arm64.tar.gz",
  "download_linux_mips_softfloat": "https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_mips_softfloat.tar.gz"
}

A filters "Check for updates" run in the GUI simply does not get done. The GUI hangs and you have to refresh. Is there any solution? I am sad

AdguardTeam / AdGuardHome