AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
24.52k stars 1.77k forks source link

Comments in ipset_file #5345

Closed NoAdO closed 5 months ago

NoAdO commented 1 year ago

Prerequisites

Description

What problem are you trying to solve?

I'm trying to add comments to /ipset.conf to organise rules. Neither

myip.ru/bypass # test

nor

myip.ru/bypass
# test
2ip.ru

work. In both cases i got dead service at Entware:

~ # nano /opt/etc/AdGuardHome/ipset.conf
~ # /opt/etc/init.d/S99adguardhome restart
 Starting AdGuardHome...              done.
~ # /opt/etc/init.d/S99adguardhome status
 Checking AdGuardHome...              dead.

Proposed solution

Any way to add comments

Additional information

AdHome v0.107.21 at Entware in Keenetic router Related Wiki-article, page search ipset_file No discussions for filter ipset_file

ghost commented 5 months ago

Hi there, are you still experiencing this?

NoAdO commented 5 months ago
myip.ru/bypass,bypass6 #test
myip.ru/bypass,bypass6
#test
windguru.cz/bypass,bypass6
windguru.cz/bypass,bypass6
;test
myip.ru/bypass,bypass6
windguru.cz/bypass,bypass6 ;test

All fail. Yes, problem still exists. No comments allowed or i do not know how to mark them.

ghost commented 5 months ago

I suppose support would need to be added for that, such as here.

Documentation

Example

Thoughts @ainar-g?

schzhn commented 5 months ago

Support for comments in the ipset file available in the edge release.

# comment
example.com/example_set