AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home.html
GNU General Public License v3.0
24.7k stars 1.79k forks source link

Bring DHCP Options to the UI #7036

Open dtx3k opened 3 months ago

dtx3k commented 3 months ago

Prerequisites

The problem

DHCP Options are available in the configuration (yaml file) using the dhcp.dhcpv4.options array field

In some cases it is not possible to edit this file, for some even to difficult unfortunately a widely used implementation of AdGuard Home, Home Assistant Addon, for example, makes it impossible to access the yaml file. nevertheless i believe the options should be available via the web interface in any case

These options are used for multiple purposes but PXE is one of the most often mentioned although #1585 #2573 #6575 do briefly mention the UI as means to configure the DHCP options, no request was opened asking this specifically

Proposed solution

Provide fields or a text box to add DHCP options in the DHCP part of the web interface of AdGuard Home So the functionality is easier to use and becomes more accessible to a wider audience and even replacing the dhcp.dhcpv4.options yaml config (or side by side)

Alternatives considered and additional information

No response

Martin-Dolan commented 2 months ago

Yes please... I'm running adguardhome on home assistant and need to add a secondary dns server so that when adguard issues dhcp ip addresses it gives each one a primary and secondary dns server. That way every client knows how to get to adguard dns, or if that is not available, the backup adguard dns I have running on another system.

Getting to adguardhome.yaml when on home assistant is nearly impossible as it's in a hidden adguardhome container.

I know it's been said in previous questions about setting a secondary dns, is that a user can break functionality of adguard if they set this incorrectly. If they put 1.1.1.1 for example in there then clients would try to access a blocked service by adguard dns and then bypass it through the secondary.

I don't agree with the break functionality excuse for not having it as an option as almost any incorrect setting will break functionality.... If I set my default gateway to the wrong IP address it would break functionality..

Having a primary and secondary instance of adguardhome running on a network (using adguardhome-sync to synchronise the DNS and dhcp static lists etc) gives high availability.
Just need to be able to set the secondary dns server in adguard...