AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home/overview.html
GNU General Public License v3.0
25.63k stars 1.84k forks source link

ipset domains editor in UI #7248

Open odcold opened 2 months ago

odcold commented 2 months ago

Prerequisites

The problem

currently ipset can be edited only by external text editor in config.yaml or standalone ipset file

Proposed solution

Add the ability to edit the ipset via the UI, and include an 'Accept Changes' button that will reload the ipset file or list contents without requiring a restart of the AGH service

Alternatives considered and additional information

No response

tjharman commented 2 months ago

Can you explain what you mean by ipset in the context of AdGuardHome? An example or screenshot or something?

odcold commented 2 months ago

@tjharman

ipset: List of domain-ipset_name associations for adding IP addresses of the specified domain names to an ipset list. Syntax:

DOMAIN[,DOMAIN,…]/IPSET_NAME[,IPSET_NAME,…]
IPv4 addresses are added to an ipset list with ipv4 family; IPv6 addresses, to an ipv6 ipset list. ipset list must exist.

This setting is supported on Linux OSs only. This feature is similar to --ipset in dnsmasq.

ipset_file (since v0.107.13): Same as ipset, but the rules are read from a file. If this property is set, property ipset is ignored. Comments (lines starting with #) are supported since v0.107.48.

from the wiki

https://github.com/AdguardTeam/AdGuardHome/wiki/Configuration

managing domains lists would be more convenient via UI

tjharman commented 2 months ago

I do apologise, this is a feature I'd missed the addition of.

odcold commented 1 month ago

@tjharman so, is there any additional info i can provide? UI can be similar to "custom filtering rules"