AdguardTeam / AdGuardHome

Network-wide ads & trackers blocking DNS server
https://adguard.com/adguard-home/overview.html
GNU General Public License v3.0
25.63k stars 1.84k forks source link

Improve Windows permission checks #7314

Closed ainar-g closed 3 weeks ago

ainar-g commented 1 month ago

Prerequisites

Platform (OS and CPU architecture)

Windows, AMD64 (aka x86_64)

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.107.53

Action

In v0.107.53 we have added a migration that should automatically detect and fix lax permissions on files on Unix-like systems. Unfortunately, the poor support of the Windows permission model from the standard Go library prevented us from doing the same on Windows.

We must find or develop libraries to make the migration and these mitigations work on Windows, as well just generally allow us to control file permissions properly.

Expected result

v0.107.53 fixes applied automatically on Windows.

Actual result

v0.107.53 fixes are not applied automatically on Windows.

Additional information and/or screenshots

No response