v0.107.54 cannot be updated to automatically and manually doing so sets wrong AdGuard folder permissions and also filters stop working

Arthur-Kenichi-Condino commented 6 days ago

Prerequisites

[X] I have checked the Wiki and Discussions and found no answer
[X] I have searched other issues and found no duplicates
[X] I want to report a bug and not ask a question or ask for help
[X] I have set up AdGuard Home correctly and configured clients to use it. (Use the Discussions for help with installing and configuring clients.)

Platform (OS and CPU architecture)

Windows, AMD64 (aka x86_64)

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.107.54

Action

AdGuard can't be updated automatically on Windows, it fails
doing it manually succeeds, but the new AdGuard stable version sets wrong permissions and makes AdGuard unusable: it sets only Write permission in many files and folders, and the result is that the user cannot access the AdGuard folder anymore and the executable cannot be run on startup, nor through PowerShell: even with administrator privileges
if you set the right permissions, AdGuard runs once and resets to the wrong ones again
if you set permissions of full control for Administrators for everything except data and the yaml file, AdGuard runs but on an unstable mode: it doesn't filter DNS requests anymore

Expected result

just a normal AdGuard update without it changing permissions in a too much restrictive way that causes the program to not be able to run, even with Administrator rights

Actual result

AdGuard blocks itself from ever being executed again after the updated first run

Additional information and/or screenshots

Some users reported this issue: https://www.reddit.com/r/AdGuardHome/comments/1gn4rjt/windows_failure_on_10754/?show=original https://www.reddit.com/r/Adguard/comments/1gmyn38/adguard_home_after_update_cannot_access/

Arthur-Kenichi-Condino commented 6 days ago

sorry if this looks like a duplicate of issue #7314, but the problem happens in this specific manner, so I started this new Issue. My AdGuardHome installation is located at C:\AdGuardHome; I'm the only user in my machine. The auto permission settings are broken to the point even the Administrators accounts can't start AdGuardHome; doing through services.msc or PowerShell causes Access Denied errors. Also, AdGuard blocks itself from running and/or reading its own files.

88keyz commented 6 days ago

Check out issue 7400.

Arthur-Kenichi-Condino commented 6 days ago

Check out issue 7400.

thank you, I think #7400 is not exactly the same, but it covers almost everything in my Issue. The only thing that is not mentioned is the item 4 in my Issue, but it is also permissions related, so maybe if 7400 has a fix, I think it'll fix this Issue too.

EDIT: and also the self-update to version v0.107.54 failure

tanmoumou252 commented 5 days ago

Exact match, after the update last night, the computer did not restart,so the problem was not discovered in time

Today, after restarting, the DNS is malfunctioning

Manually reopening the AdGuardHome service or checking files in the AdGuardHome installation directory will be denied

Removing the installation directory using rd /s/q *path* will show that some files are in use and cannot be accessed

Fortunately, there's a backup. I've rolled back to the previous version now

AdguardTeam / AdGuardHome