AdguardTeam / AdGuardSDNSFilter

AdGuard DNS filter
https://adguard-dns.io/
GNU General Public License v3.0
765 stars 129 forks source link

Could the anti-threat file(s) of hostsVN be considered for inclusion? #1575

Closed DandelionSprout closed 7 months ago

DandelionSprout commented 8 months ago

Prerequisites

Problem description

I looked around on hostsVN's repo at https://github.com/bigdargon/hostsVN/tree/master some minutes ago, and came across https://github.com/bigdargon/hostsVN/blob/master/extensions/threat/filter-VN.txt

Seeing as the repo's anti-ad file has been included in AdGuard DNS Filter for 3-4 years by now, I presume the repo's anti-malware file would be suited to be added to DNS Filter's lineup too.

Proposed solution

Add either https://raw.githubusercontent.com/bigdargon/hostsVN/master/extensions/threat/filter.txt or https://raw.githubusercontent.com/bigdargon/hostsVN/master/extensions/threat/filter-VN.txt to https://github.com/AdguardTeam/AdGuardSDNSFilter/blob/master/configuration.json . There's not a whole lot of differences between the two, so I'd say it's a 55:45 call which one to add.

Additional information

I haven't had the best of years in 2023, and as a result of that I began presuming that an issue report would seem less brash and criticisable than a PR.

The same repo also has an ip folder, but I presumed that adding more than 6,000 IPs from that particular folder to AdGuard DNS Filter would likely become a problem.

Alex-302 commented 7 months ago

https://raw.githubusercontent.com/bigdargon/hostsVN/master/extensions/threat/filter.txt

is ok. @jellizaveta please add it to https://github.com/AdguardTeam/AdGuardSDNSFilter/blob/master/configuration.json as a new section like https://github.com/AdguardTeam/AdGuardSDNSFilter/blob/master/configuration.json#L296C16-L296C34

bigdargon commented 7 months ago

@DandelionSprout Thank you for your suggestion!