Alex-302
commented
3 months ago The problem is that this filter includes rules that can break sites, incl. non-advertising. 90 rules are badfiltered.
Open DandelionSprout opened 3 months ago
Alex-302
commented
3 months ago The problem is that this filter includes rules that can break sites, incl. non-advertising. 90 rules are badfiltered.
Alex-302
commented
3 months ago Also it seems 5700 domains in your list are dead:) Liste.FR.AdGuard.DNS.Filter.testing-dead.txt
DandelionSprout
commented
3 months ago Certainly explains a bit. 😅 It probably should've struck me to run PyFunceble on the results, but when more than half of them are dead, maybe someone should tell Liste FR to run PyFunceble on their list upstream first.
DandelionSprout
commented
3 months ago Based on this tip, I created https://github.com/easylist/listefr/pull/177 over at his repo, and I presume I'm awaiting his decision on the PR before I'd attempt a new conversion of some sort.
DandelionSprout
commented
2 months ago He apparently did not get the memo at https://github.com/easylist/listefr/pull/177. At all.
I'll see when, and if so how, I'll do a 2nd attempt at this issue report.
DandelionSprout
commented
2 months ago To play it ultra-hyper-safe, by almost only including domains with the word ads in them, or which began with ad. At that point it's a matter of covering French users to a basic extent, and not to take some workloads off my shoulders.
Alex-302
commented
2 months ago Dead:
The rest - checked few random domains - they are not used (adsplex.com), not respond or owned probably by spammers (like admtpmp123.com, admtpmp124.com)
Prerequisites
Problem description
It has been established for some time that the 23 entries from https://raw.githubusercontent.com/AdguardTeam/AdguardFilters/master/FrenchFilter/sections/adservers.txt and https://raw.githubusercontent.com/AdguardTeam/AdguardFilters/master/FrenchFilter/sections/adservers_firstparty.txt is a tad little, even if the reasoning is decent enough.
Nevertheless, I gave it a try to see "Okay, how many entries from Liste FR would be mostly okay to propose adding to DNS Filter somehow?"
The process wasn't super-easy, and would be a nightmare to automate, but I landed on the 8,462 entries in the attachment below.
Proposed solution
I went through the entirety of https://filters.adtidy.org/extension/ublock/filters/16.txt, and narrowed down the entries until the remaining ones were generally those that would make sense in DNS filtering:
Liste.FR.AdGuard.DNS.Filter.testing.txt (I apparently didn't even need to compress the file this time around.)
Additional information
I can see that https://github.com/AdguardTeam/AdGuardSDNSFilter/issues/970 discussed it to a basic extent, so I decided to play it really, really safe with the pasted file, to the point I even discarded
$third-partyentries; as well as almost all entries that ended with a period (.), and IP entries.Liste FR conversions were one of the things that really made https://raw.githubusercontent.com/DandelionSprout/adfilt/master/AdGuard%20Home%20Compilation%20List/AdGuardHomeCompilationList.txt stand out from AdGuard DNS Filter, but as I gradually began losing energy to maintain the former, an inclusion of Liste FR of some sort in AdGuard DNS Filter would help me gradually narrow down the amount of entries and needed maintenance in my list, as I began conceding defeat to DNS Filter.
Nevertheless, my list still converts a few other lists that DNS Filter doesn't (Primarily EasyList Spanish, Liste AR, uBlock Filters, and Adblock Warning Removal List).